From: Oleg Pykhalov <go.wigust@gmail.com>
To: lgcoelho@disroot.org
Cc: 68010@debbugs.gnu.org
Subject: [bug#68010] [PATCH] home: services: Add home-zathura-service-type.
Date: Tue, 23 Jan 2024 16:09:09 +0300 [thread overview]
Message-ID: <875xzk8adm.fsf@gmail.com> (raw)
In-Reply-To: <a4e1ffea3e66951afff930078db97976@disroot.org> (lgcoelho@disroot.org's message of "Sun, 24 Dec 2023 18:26:19 +0000")
[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]
Hello, Luis.
Apologies for delay.
Could you send a new patch with applied following suggestions, please?
lgcoelho@disroot.org writes:
> This service enables a declarative configuration of zathura, the customizable
> document viewer.
>
> commit 76954ed7dc32ac86ee22566cc03cadc5f9fc1864
> Author: Luis Guilherme Coelho <lgcoelho@disroot.org>
> Date: Sun Dec 24 15:16:43 2023 -0300
>
> home: services: Add home-zathura-service-type
The commit message should look like:
--8<---------------cut here---------------start------------->8---
home: services: Add zathura service.
* gnu/home/services/zathura.scm: New file.
* doc/guix.texi (SPECIFY SECTION HERE): Document this.
--8<---------------cut here---------------end--------------->8---
> diff --git a/gnu/home/services/zathura.scm b/gnu/home/services/zathura.scm
> new file mode 100644
> index 0000000000..0695ce1614
> --- /dev/null
> +++ b/gnu/home/services/zathura.scm
[…]
> +(define home-zathura-service-type
> + (service-type
> + (name 'zathura-service)
> + (extensions
> + (list (service-extension
> + home-xdg-configuration-files-service-type
> + zathura-xdg-configuration-file-service)))
> + (compose identity)
> + (extend home-zathura-extensions)
> + (default-value (home-zathura-configuration))
> + (description "Set ~/.config/zathura.conf")))
Description should mention that the service configures the Zathura PDF
viewer, e.g.:
Configure the Zathura PDF viewer by providing a
@file{~/.config/zathura.conf} file.
> +(define (generate-doc)
> + (configuration->documentation 'home-zathura-configuration))
The service documentation should be added to doc/guix.texi file.
See ZNC home service as an example.
Fields documentation could be generated with:
--8<---------------cut here---------------start------------->8---
~/src/git.savannah.gnu.org/git/guix$ ./pre-inst-env guix repl
GNU Guile 3.0.9
Copyright (C) 1995-2023 Free Software Foundation, Inc.
Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.
Enter `,help' for help.
scheme@(guix-user)> ,m(gnu home services zathura)
scheme@(gnu home services zathura)> (generate-doc)
--8<---------------cut here---------------end--------------->8---
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2024-01-23 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 18:26 [bug#68010] [PATCH] home: services: Add home-zathura-service-type lgcoelho--- via Guix-patches via
2023-12-26 9:33 ` Sergey Trofimov
2023-12-26 12:11 ` Oleg Pykhalov
2024-01-08 8:46 ` Ludovic Courtès
2024-01-23 13:09 ` Oleg Pykhalov [this message]
2024-01-23 13:13 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xzk8adm.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=68010@debbugs.gnu.org \
--cc=lgcoelho@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).