unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#70563] [PATCH] gnu: Add pkcs11-helper.
@ 2024-04-25  9:22 Andy Tai
       [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Andy Tai @ 2024-04-25  9:22 UTC (permalink / raw)
  To: 70563; +Cc: Andy Tai

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 00a7f97582..5e20424001 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,30 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [bug#70563] Acknowledgement ([PATCH] gnu: Add pkcs11-helper.)
       [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
@ 2024-04-30 19:21   ` Andy Tai
  0 siblings, 0 replies; 11+ messages in thread
From: Andy Tai @ 2024-04-30 19:21 UTC (permalink / raw)
  To: 70563

patch passed QA
https://qa.guix.gnu.org/issue/70563




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563]
  2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
       [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
@ 2024-05-02 21:21 ` Andy Tai
  2024-05-13  7:01 ` [bug#70563] QA review for 70563 Nicolas Graves via Guix-patches via
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Andy Tai @ 2024-05-02 21:21 UTC (permalink / raw)
  To: 70563

patch passed QA

https://qa.guix.gnu.org/issue/70563




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] QA review for 70563
  2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
       [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
  2024-05-02 21:21 ` [bug#70563] Andy Tai
@ 2024-05-13  7:01 ` Nicolas Graves via Guix-patches via
  2024-05-13 12:34   ` Ludovic Courtès
  2024-05-16  5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
  2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
  4 siblings, 1 reply; 11+ messages in thread
From: Nicolas Graves via Guix-patches via @ 2024-05-13  7:01 UTC (permalink / raw)
  To: control, 70563

user guix
usertag 70563 + reviewed-looks-good
thanks

Guix QA review form submission:
The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 

Otherwise LGTM.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests

-- 
Best regards,
Nicolas Graves




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] QA review for 70563
  2024-05-13  7:01 ` [bug#70563] QA review for 70563 Nicolas Graves via Guix-patches via
@ 2024-05-13 12:34   ` Ludovic Courtès
  2024-05-13 14:09     ` Andy Tai
  0 siblings, 1 reply; 11+ messages in thread
From: Ludovic Courtès @ 2024-05-13 12:34 UTC (permalink / raw)
  To: Nicolas Graves, Andy Tai; +Cc: control, 70563

Hi Andy,

Did you receive Nicolas’ message below?

Nicolas Graves <ngraves@ngraves.fr> skribis:

> user guix
> usertag 70563 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 
>
> Otherwise LGTM.

Note that despite being marked as “reviewed-looks-good”, Nicolas makes
a suggestion that I think is worth addressing in a second version.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] QA review for 70563
  2024-05-13 12:34   ` Ludovic Courtès
@ 2024-05-13 14:09     ` Andy Tai
  0 siblings, 0 replies; 11+ messages in thread
From: Andy Tai @ 2024-05-13 14:09 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 70563, control, Nicolas Graves

OK I did not see that reply in email but I will send v2 patch
addressing the comment

On Mon, May 13, 2024 at 5:34 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hi Andy,
>
> Did you receive Nicolas’ message below?
>
> Nicolas Graves <ngraves@ngraves.fr> skribis:
>
> > user guix
> > usertag 70563 + reviewed-looks-good
> > thanks
> >
> > Guix QA review form submission:
> > The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that.
> >
> > Otherwise LGTM.
>
> Note that despite being marked as “reviewed-looks-good”, Nicolas makes
> a suggestion that I think is worth addressing in a second version.
>
> Thanks,
> Ludo’.



-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2024 民國113年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] [PATCH v2] gnu: Add pkcs11-helper.
  2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
                   ` (2 preceding siblings ...)
  2024-05-13  7:01 ` [bug#70563] QA review for 70563 Nicolas Graves via Guix-patches via
@ 2024-05-16  5:42 ` Andy Tai
  2024-05-22  5:34   ` Z572
  2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
  4 siblings, 1 reply; 11+ messages in thread
From: Andy Tai @ 2024-05-16  5:42 UTC (permalink / raw)
  To: 70563, ngraves, ludo; +Cc: Andy Tai

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..78ddf5456b 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [bug#70563] [PATCH v2] gnu: Add pkcs11-helper.
  2024-05-16  5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
@ 2024-05-22  5:34   ` Z572
  2024-05-22  6:16     ` Andy Tai
  0 siblings, 1 reply; 11+ messages in thread
From: Z572 @ 2024-05-22  5:34 UTC (permalink / raw)
  To: Andy Tai; +Cc: ngraves, ludo, 70563

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

Andy Tai <atai@atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..78ddf5456b 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl-1.1 pcsc-lite))

Can this package use openssl-3.0? As i known, openssl 1.1 is EOL,
see https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/index.html.
It is best not to add more openssl-1.1 dependencies.  other LGTM.

> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] [PATCH v2] gnu: Add pkcs11-helper.
  2024-05-22  5:34   ` Z572
@ 2024-05-22  6:16     ` Andy Tai
  0 siblings, 0 replies; 11+ messages in thread
From: Andy Tai @ 2024-05-22  6:16 UTC (permalink / raw)
  To: Z572; +Cc: ngraves, ludo, 70563

will check and possible update patch




^ permalink raw reply	[flat|nested] 11+ messages in thread

* [bug#70563] [PATCH v3] gnu: Add pkcs11-helper.
  2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
                   ` (3 preceding siblings ...)
  2024-05-16  5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
@ 2024-05-22 17:31 ` Andy Tai
  2024-05-23  5:34   ` bug#70563: " Zheng Junjie
  4 siblings, 1 reply; 11+ messages in thread
From: Andy Tai @ 2024-05-22 17:31 UTC (permalink / raw)
  To: 70563; +Cc: Andy Tai

* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..939febd4e3 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 11+ messages in thread

* bug#70563: [PATCH v3] gnu: Add pkcs11-helper.
  2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
@ 2024-05-23  5:34   ` Zheng Junjie
  0 siblings, 0 replies; 11+ messages in thread
From: Zheng Junjie @ 2024-05-23  5:34 UTC (permalink / raw)
  To: Andy Tai; +Cc: 70563-done

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

Andy Tai <atai@atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..939febd4e3 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl pcsc-lite))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42

push, see https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d4118a34e34554592a777000497f2c3d33fc6f5b

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-05-23  5:36 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-25  9:22 [bug#70563] [PATCH] gnu: Add pkcs11-helper Andy Tai
     [not found] ` <handler.70563.B.171403701115514.ack@debbugs.gnu.org>
2024-04-30 19:21   ` [bug#70563] Acknowledgement ([PATCH] gnu: Add pkcs11-helper.) Andy Tai
2024-05-02 21:21 ` [bug#70563] Andy Tai
2024-05-13  7:01 ` [bug#70563] QA review for 70563 Nicolas Graves via Guix-patches via
2024-05-13 12:34   ` Ludovic Courtès
2024-05-13 14:09     ` Andy Tai
2024-05-16  5:42 ` [bug#70563] [PATCH v2] gnu: Add pkcs11-helper Andy Tai
2024-05-22  5:34   ` Z572
2024-05-22  6:16     ` Andy Tai
2024-05-22 17:31 ` [bug#70563] [PATCH v3] " Andy Tai
2024-05-23  5:34   ` bug#70563: " Zheng Junjie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).