From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2DDCB/v8WWa1HgEAA41jLg (envelope-from ) for ; Fri, 31 May 2024 18:38:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CBJzO/r8WWag0AAA62LTzQ (envelope-from ) for ; Fri, 31 May 2024 18:38:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=auVVr8uc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717173498; a=rsa-sha256; cv=none; b=qxJ/HUoBWlrrJ3+ZabGja1t6C6FWlsBQ/WsvmabESSY73/ywXps1FZOV+QEX9KuBXNsjIT GaHGq+ZUUGL1EkSP3drx8xhu5jba6YCB/AOQHGHIvta2p92CLRcE5s/vfvIx1ZNiTpSOYb eae5WT67OSc10IkcpTI5tP1n6USMWLbS+V1AiGsVZKn35pyfxa30ZXODxv7qdocLvgyvNq eLserExQGBaqeCd9Bvdq8Q8SqhO887J4gp2PUD2tYTpPnuahht3EQhg2sIAMkKcVkGgTSv RS8s4GJjGbYp6l4EzGspSXbcrORjQa676Tue/M4lmZERWtRJrCYJoDtARrpWkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=auVVr8uc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717173498; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2s8RGNclctcIBtWJLPB7LaxAbO9RbJk2pOFDn2shwjE=; b=cDSy/XMl2hRQ/8yjw+RIh+xSotjnamJcAmqM54cDbFu4Z0EkHKjSjRAfJ8TG94Yq0xeggA deAxyCCtPrsezthP4iQjGGMD1p/4iiol38UTrW4pXaUV5nqrEcHEeTETXPYldpGqYuyTBO VtDPHXKUTIgDcOxiTS/IWTwhU0JUo6tCrkrwFpLiN59DNE/R1VpTxH5aYydtVA7JCBuWEL paT+/vCRVomllIZ1J15inc6po13ikDw44NWpfUVIvDygZIK61kMjzVdWinptjjst8qwQ9C CWlkGvPwjhAENxgFq/LG3DSGyWsawmlTltxpjsn2oT8T0uXCbg0x4gWMT+cMqg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95AA3125B7 for ; Fri, 31 May 2024 18:38:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sD5GM-0000Un-24; Fri, 31 May 2024 12:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sD5GK-0000To-On for guix-patches@gnu.org; Fri, 31 May 2024 12:37:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sD5GK-0004MS-ET for guix-patches@gnu.org; Fri, 31 May 2024 12:37:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sD5GV-00013E-He for guix-patches@gnu.org; Fri, 31 May 2024 12:38:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71038] [PATCH 1/2] guix: store: Enable specifying the available builtin builders. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 May 2024 16:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71038 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 71038@debbugs.gnu.org Received: via spool by 71038-submit@debbugs.gnu.org id=B71038.17171734223905 (code B ref 71038); Fri, 31 May 2024 16:38:03 +0000 Received: (at 71038) by debbugs.gnu.org; 31 May 2024 16:37:02 +0000 Received: from localhost ([127.0.0.1]:55242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD5FV-00010k-MI for submit@debbugs.gnu.org; Fri, 31 May 2024 12:37:02 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD5FT-00010P-Tf for 71038@debbugs.gnu.org; Fri, 31 May 2024 12:37:01 -0400 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42129d4e7bdso1461785e9.1 for <71038@debbugs.gnu.org>; Fri, 31 May 2024 09:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717173343; x=1717778143; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2s8RGNclctcIBtWJLPB7LaxAbO9RbJk2pOFDn2shwjE=; b=auVVr8ucHPWjd5atrh2wbGW+ft3+DJQnmCxdqYOxCGxpMI1ZJN9WhxGqmgSr0hmspy NwMoCmIORB9uN1IGFW81k3tOeuticIicHpngddPVat+4RyEul5XMIfJdIfyB7IuHok4h rM53dpk0wEkG6+xtn51gWhuIPSSP+S1fLzfOCgoAwLWZzmTh3BMC/k7UZGDQ8GvUFXoN 4UgMSdNORsHKax1eq4JN8BCBwY5AVIXjPS/NNdRxK5BKM3AVv8Jti9rdgHm8tpK9Dxry OTTAJmy5O0UZ9aY9mBDB7rcLA9W94dLW9Og1tGNLiqsg4LFllJlXETIORGUXWdWnrUXe YQ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717173343; x=1717778143; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2s8RGNclctcIBtWJLPB7LaxAbO9RbJk2pOFDn2shwjE=; b=ZuVtdARrENEFnj3q8KBEWFGTagNjYhzO2QPcrP1JWW5ob4kdDeAtXPH/1XRkjodATS ousuJnanu7umB8IGZKsosW3q13fbFXio5QAf9j/m6Gn5rEfR835MJluG2ZsGy/GwbT/h OGo5j3OV2GVyp3KUlwP1OBysX2c8WuvT65aUyEp6w/R7oRziginYCxIswSVVSegPuq8O xwQQP/h7s6Og0lKombEUCxjcc2mSvFWFl18HywcJcJNeVqtUSwRIv26xkuM9/Usy4cM7 ZqcmBAblGzYCtmM0xR06/uzCldYxJF8EvJ5CkDTjSUUY+HdA/wXaBmanH2clC2/1HvBU CRkA== X-Forwarded-Encrypted: i=1; AJvYcCXpgzmV5wl+SpiXet2wWScnA/sik6jzts4o+gZMT6Yp8K5sSXESMh287MYRFCksdaRap7y8gD8427b68MyF8fO6rCczUR4= X-Gm-Message-State: AOJu0YzSCDZ/AfrqnrhRn/fF4PKdjEpLxgY8mbhHSkXZUtSWvdOG8dnH RUdB2VDGgG4z3yEbhsrKdGxdio2KVlcIjo/6grxmxXbsDaB9o2aoDMq7ww== X-Google-Smtp-Source: AGHT+IEuafFuhtukyUz1PKmxYS8I1MVoDxghEadm976b8JUpu4yDl9KiZ0SH2GPPbc8Xhdkf/6POnA== X-Received: by 2002:adf:f387:0:b0:354:f46f:a5b5 with SMTP id ffacd0b85a97d-35e0f2e0062mr1763568f8f.3.1717173342586; Fri, 31 May 2024 09:35:42 -0700 (PDT) Received: from lili ([81.185.168.12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd064b5e9sm2194234f8f.96.2024.05.31.09.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 09:35:41 -0700 (PDT) From: Simon Tournier In-Reply-To: <87sey5f0xr.fsf@cbaines.net> References: <87y187b6xv.fsf@cbaines.net> <6b9c634c024b6fd7a50d3b82edc244676a8ca8e8.1716038375.git.mail@cbaines.net> <87a5ki3ygr.fsf@gmail.com> <87sey5f0xr.fsf@cbaines.net> Date: Mon, 27 May 2024 19:19:07 +0200 Message-ID: <875xuz18c4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 95AA3125B7 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 3.65 X-Spam-Score: 3.65 X-TUID: 4xGZk0q2aYqz Hi Chris, On Sun, 26 May 2024 at 09:10, Christopher Baines wrote: >>> (define* (open-connection #:optional (uri (%daemon-socket-uri)) >>> #:key port (reserve-space? #t) cpu-affinity >>> - non-blocking?) >>> + non-blocking? assume-available-builtin-build= ers) >> >> Why add the variable %assume-available-builtin-builders and default to >> it? >> >> Something like: >> >> --8<---------------cut here---------------start------------->8--- >> (define %assume-available-builtin-builders >> "List of builtin builders supported by the builder Guix daemon." >> (list "download" "git-download")) >> >> (define* (open-connection #:optional (uri (%daemon-socket-uri)) >> #:key port (reserve-space? #t) cpu-affinity >> non-blocking?) >> non-blocking? >> (assume-available-builtin-builders %assume-ava= ilable-builtin-builders)) >> --8<---------------cut here---------------end--------------->8--- >> >> And then default to this %assume-available-builtin-builders elsewhere in >> [PATCH 2/2]. IMHO, it changes almost nothing but it would help to know >> (document) what to pass as argument. > > I think it's sensible to not use a fixed list by default, but check what > the daemon supports. Do you mean dynamically construct the proposal of %assume-available-builtin-builders? Why not. Aside, my point is to provide a default value for the new argument and not let it free. Because when reading the source code, not knowing its type, neither any meaningful value make it hard to remember what it use or how to use it, IMHO. That=E2=80=99s why I am suggesting something like %assume-available-builtin-builders that collects the acceptable values =E2=80=93 for the most recent daemon, indeed; well it would simplify the documentation of this new parameter / argument. Considering your patch, how do I know that I could used it, as [1]: --8<---------------cut here---------------start------------->8--- As in: (open-connection #:assume-available-builtin-builders '("download")) --8<---------------cut here---------------end--------------->8--- Because it is not clear from the docstring. And there is many procedures that would require some docstring update with this new procedure argument. :-) 1: bug#67250: builtin:git-download capability detection not working for the= bordeaux build farm Ludovic Court=C3=A8s Wed, 22 Nov 2023 11:19:42 +0100 id:87bkbmm6o1.fsf@gnu.org https://issues.guix.gnu.org/67250 https://issues.guix.gnu.org/msgid/87bkbmm6o1.fsf@gnu.org https://yhetil.org/guix/87bkbmm6o1.fsf@gnu.org Cheers, simon