From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QAg1HmKi6WbZjQAAqHPOHw:P1 (envelope-from ) for ; Tue, 17 Sep 2024 15:38:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QAg1HmKi6WbZjQAAqHPOHw (envelope-from ) for ; Tue, 17 Sep 2024 17:38:10 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="uaLr7gV/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nWI6Y+MR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726587490; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/ZMlZuKLvtZfWApjP0Q462ungAeDzHTRqMrYQHQ13xo=; b=iYYgt+3bUudtHqmRfFJz5z65CaHnoFr99B1U0raclkqw40CzpHSHnIwBBbG+CfJsH7vAlt o75LMW0a99pXdYJshTXZhSmz7dXuDgLZehRtfsTXBvH1w2smSNQ6vz7B6w61lc9n5rPruO cvQeywtxaFNXTQijLsRA7q/5xf8+trfBFsXq96eR3NoXuvTIQrWuccxYDbwbINjQKTiAlW fNKMDRd3OvDta9Vqcwu9by/dUvA5mGsyhgYbt50kghnf9hYH27a+zIM95CNvMyodxbQJoy Xo7eb/+ac2EfgXByRrBA88n3+H+0xkqIGt2UOeUztsaux8fVYjqCxDlnxXy0uQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726587490; a=rsa-sha256; cv=none; b=GawhfH2uDNXuVVMrKdmk7/MBBMyiPdLHOLSfK7G74sHFhyvoheOQUDF3VNhdqaWz1t16Y7 iv+ciW2pQVWvALzaSZpPzVwO7hotDk3D1Jb3rUZ00oop16rAwzQvxpBZY6If8cRC66oiy3 8c7nGD/EW6D+D8qTaSPWMp0YcJsUQODPtvdhrGIDJAnhhRqlyS59H/fombCyiNKcNuQC+z RmHWqaRXLAjvoiS4J5CDl4pKujVRFUMfVXDG3kdGn8o3Gu+NRwep7+PvJQr3/OqHN37+jV 1ZPK54pDSYuWhPUy9ETkeIeyHsWN8MuTT2uT1kjuJL+9lXJSq7qQn0Vpd7WwaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="uaLr7gV/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nWI6Y+MR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 502667E355 for ; Tue, 17 Sep 2024 17:38:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqaGy-00043S-Vh; Tue, 17 Sep 2024 11:37:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqaGx-00043C-Gx for guix-patches@gnu.org; Tue, 17 Sep 2024 11:37:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqaGx-0000LO-7c for guix-patches@gnu.org; Tue, 17 Sep 2024 11:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=/ZMlZuKLvtZfWApjP0Q462ungAeDzHTRqMrYQHQ13xo=; b=uaLr7gV/Iwenw5zjBC9253+ba4ICv/eT3kTavmTbu+PK06Gltx/G+NKJoPUI9NHdZAoDd44bopPKLhhF9ZclSaCtz4cg1keSYAoPxJO6KI+tyarjMGEfgX0VauhosyFIG7sgnsGsHU3nJXDTEVTP7mx0D8uTkuFgMiJLfoPlQwpaZWroPlDhZ7OTwYj2zSe/miDLD/PLDGl9kuIxuq8hucNTTAkKUdWU9jIAP4WmQd4RykedTZKhEPw1WdRHxXn9N2eD7EV7jPVAku49WT6aXZmfNgk/X0BcJjGdzBGlmbw+ZKNcpSUvihzgua95xGe6HB2oQR6tDlF9abdG5VF5mw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqaHC-0003oP-0k for guix-patches@gnu.org; Tue, 17 Sep 2024 11:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71764] [PATCH v7] gnu: Add got. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Sep 2024 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71764 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ashish SHUKLA Cc: 71764@debbugs.gnu.org Received: via spool by 71764-submit@debbugs.gnu.org id=B71764.172658742714568 (code B ref 71764); Tue, 17 Sep 2024 15:38:01 +0000 Received: (at 71764) by debbugs.gnu.org; 17 Sep 2024 15:37:07 +0000 Received: from localhost ([127.0.0.1]:55761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqaGI-0003mt-Gi for submit@debbugs.gnu.org; Tue, 17 Sep 2024 11:37:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqaGG-0003mN-Fh for 71764@debbugs.gnu.org; Tue, 17 Sep 2024 11:37:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqaFv-0000JJ-Dd; Tue, 17 Sep 2024 11:36:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/ZMlZuKLvtZfWApjP0Q462ungAeDzHTRqMrYQHQ13xo=; b=nWI6Y+MRzzGN3NSOfoeh Lkv0M3PZmmPY3qtUvfMVHpD31JsmwSMzw3uR7QKBLj9QxxGJnH4DYIPUU1AXqQhBqd2/4tj7FOwkr 8vt0o644VtPZXnPIadeHOuYeAn66w6RjXp6yaJ8dYDu8FAQl0UrXKFLgVKqxxQXbhC3Y4y9FBgI+M dYVPOdd02L1ZA0qyayPbDMWQzvclVA5eYGxnD+RMC/8sO6U+UoZVQ9kd8hkkX9UPvaii4W66+2oB4 BNzAiros9mnBHVTQakQ7IURq7Pvhp1UX/R5EQKHaY/TWJvtm6T/kAR6Ej2OQ1fXdinDeof1fNiXQA CA0NikdRwNHHWw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <2b3365852f7368a67199c3b84e1502f6d499e379.1726149620.git.ashish.is@lostca.se> (Ashish SHUKLA's message of "Thu, 12 Sep 2024 14:00:21 +0000") References: <2b3365852f7368a67199c3b84e1502f6d499e379.1726149620.git.ashish.is@lostca.se> Date: Tue, 17 Sep 2024 17:36:14 +0200 Message-ID: <875xqu9tsh.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.10 X-Migadu-Queue-Id: 502667E355 X-Spam-Score: -9.10 X-TUID: 9CNti9j7rv5c Hi, Ashish SHUKLA skribis: > * gnu/packages/version-control.scm (got): New variable. > > Change-Id: I34d19d90ab36e8831fa88668676aa2399356b002 [...] > +(define-public got [...] > + (inputs > + `(("libevent" ,libevent) > + ("libuuid" ,util-linux "lib") > + ("zlib" ,zlib) > + ("libressl" ,libressl) > + ("libmd" ,libmd) > + ("libbsd" ,libbsd) > + ("ncurses" ,ncurses))) Please run =E2=80=98guix style -S inputs --input-simplification=3Dalways go= t=E2=80=99. > + `(;; disable runpath validation, courtesy: libbsd's special > + ;; treatment of libmd > + #:validate-runpath? #f It isn=E2=80=99t clear from the comment why RUNPATH validation is disabled,= and there has to be a very good reason because usually any problem it detects is going to be an issue at run time. Could you double-check? > + #:configure-flags > + '("CFLAGS=3D-DGOT_DIAL_PATH_SSH=3D\\\"ssh\\\" -DGOT_TAG_PATH_SSH_= KEYGEN=3D\\\"ssh-keygen\\\" -DGOT_TAG_PATH_SIGNIFY=3D\\\"signify\\\"") Please wrap lines to 80 characters. Also, setting CFLAGS like this runs the risk of overriding the default, which are usually =E2=80=9C-O2 -g=E2=80=9D, and thus building without optim= izations. Could you check whether this is the case and perhaps add =E2=80=9C-O2 -g=E2= =80=9D? > + #:phases ,#~(modify-phases %standard-phases > + (add-after 'unpack 'patch-execv-to-execvp > + (lambda _ > + ;; got sources has paths hardcoded to /usr/bin > + (substitute* "lib/dial.c" > + (("execv\\(GOT_DIAL_") "execvp(GOT_DIAL_") > + (("execv %s\", GOT_DIAL") "execvp %s\", GOT_DI= AL")) > + (substitute* "lib/sigs.c" > + (("execv\\(GOT_TAG") "execvp(GOT_TAG") > + (("execv %s\", GOT_TAG") "execvp %s\", GOT_TAG= ")) > + #t))))) Please remove the trailing #t. Could you send an updated patch? Thanks, Ludo=E2=80=99.