From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 73682@debbugs.gnu.org
Subject: [bug#73682] [PATCH 3/3] gnu: varnish: Improve style.
Date: Tue, 15 Oct 2024 18:25:55 +0200 [thread overview]
Message-ID: <875xptwcx8.fsf@gnu.org> (raw)
In-Reply-To: <20241008062144.22558-3-ngraves@ngraves.fr> (Nicolas Graves's message of "Tue, 8 Oct 2024 08:21:41 +0200")
Nicolas Graves <ngraves@ngraves.fr> skribis:
> * gnu/packages/web.scm (varnish): Improve style.
> [arguments]: Rewrite using gexps.
> [inputs]: Replace coreutils by coreutils-minimal, python by
> python-minimal. Add glibc.
[...]
> + ;; Varnish uses GCC to compile VCL, so wrap it with required GCC
> + ;; environment variables to avoid propagating them to profiles.
> + (lambda _
> + (wrap-program (string-append #$output "/sbin/varnishd")
> ;; Add binutils to PATH so gcc finds the 'as' executable.
> - `("PATH" ":" prefix (,PATH))
> + `("PATH" ":" prefix (,(dirname (which "as"))))
> ;; Make sure 'crti.o' et.al is found.
> - `("LIBRARY_PATH" ":" prefix (,LIBRARY_PATH)))))))))
> + `("LIBRARY_PATH" ":" prefix
> + (,#$(file-append (this-package-input "glibc") "/lib"))))))))))
If we assume we’ll never want to cross-compile Varnish (sounds
reasonable to me), use:
(dirname (search-input-file inputs "/lib/libc.so"))
and do *not* add ‘glibc’ as an input, as this effectively adds a
dependency on a second glibc.
Ludo’.
next prev parent reply other threads:[~2024-10-15 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 21:54 [bug#73682] [PATCH 0/3] gnu: varnish: Update to 7.6.0. [security fixes] Nicolas Graves via Guix-patches via
2024-10-07 22:07 ` [bug#73682] [PATCH 1/3] " Nicolas Graves via Guix-patches via
2024-10-08 6:21 ` [bug#73682] [PATCH 2/3] gnu: varnish-modules: Update to 0.25.0 Nicolas Graves via Guix-patches via
2024-10-08 6:21 ` [bug#73682] [PATCH 3/3] gnu: varnish: Improve style Nicolas Graves via Guix-patches via
2024-10-15 16:25 ` Ludovic Courtès [this message]
2024-10-15 19:56 ` [bug#73682] [PATCH v2 1/3] gnu: varnish: Update to 7.6.0. [security fixes] Nicolas Graves via Guix-patches via
2024-10-15 19:56 ` [bug#73682] [PATCH v2 2/3] gnu: varnish-modules: Update to 0.25.0 Nicolas Graves via Guix-patches via
2024-10-15 19:56 ` [bug#73682] [PATCH v2 3/3] gnu: varnish: Improve style Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xptwcx8.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=73682@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).