unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Richard Sent <richard@freakingpenguin.com>
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>, 74837-done@debbugs.gnu.org
Subject: bug#74837: [PATCH v3 0/2] resize-file-system-service
Date: Mon, 16 Dec 2024 00:02:33 +0100	[thread overview]
Message-ID: <875xnkh7na.fsf@gnu.org> (raw)
In-Reply-To: <cover.1734211103.git.richard@freakingpenguin.com> (Richard Sent's message of "Sat, 14 Dec 2024 16:18:21 -0500")

Hi,

Richard Sent <richard@freakingpenguin.com> skribis:

> What would that look like? We don't want to capture an error in
> grow-filesystem-command with an exit-status of 1, so it lives outside
> the guard, and we don't want to raise an exception if the partition
> was already resized.

Ah yes, that makes sense, sorry for misunderstanding.

> (Side note, should Shepherd consider a service perpetually starting if
> the start constructor exits without returning a value?)

A constructor must return exactly one value.  (Or it can throw an
exception, which is interpreted as failure to start.)

> V3 should have all other feedback implemented.
>
> Richard Sent (2):
>   packages: cloud-utils: Add missing growpart programs to path.
>   gnu: services: Add resize-file-system-service.

Perfect.  Applied, thanks!

Ludo’.




      parent reply	other threads:[~2024-12-15 23:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 20:16 [bug#74837] [PATCH 0/2] Add resize-fs service Richard Sent
2024-12-12 20:18 ` [bug#74837] [PATCH 1/2] gnu: services: Add resize-fs-service Richard Sent
2024-12-12 20:19 ` [bug#74837] [PATCH 2/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-12 21:15 ` [bug#74837] [PATCH v2 1/2] gnu: services: Add resize-fs-service Richard Sent
2024-12-12 21:15   ` [bug#74837] [PATCH v2 2/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-14 15:23   ` [bug#74837] [PATCH v2 1/2] gnu: services: Add resize-fs-service Ludovic Courtès
2024-12-14 21:18 ` [bug#74837] [PATCH v3 0/2] resize-file-system-service Richard Sent
2024-12-14 21:18   ` [bug#74837] [PATCH v3 1/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-14 21:18   ` [bug#74837] [PATCH v3 2/2] gnu: services: Add resize-file-system-service Richard Sent
2024-12-15 23:02   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xnkh7na.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74837-done@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=richard@freakingpenguin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).