unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 73993@debbugs.gnu.org
Subject: [bug#73993] [PATCH v2 2/3] gnu: git-sizer: Use gexps.
Date: Wed, 18 Dec 2024 12:03:13 +0100	[thread overview]
Message-ID: <875xnhmexa.fsf@gnu.org> (raw)
In-Reply-To: <5fb143fe5d3b981106d71d9d029d026a732982c2.1733430615.git.code@greghogan.com> (Greg Hogan's message of "Thu, 5 Dec 2024 21:04:32 +0000")

Greg Hogan <code@greghogan.com> skribis:

> * gnu/packages/version-control.scm (git-sizer)
> [arguments]<#:phases>: Use gexps.
>
> Change-Id: Ic2c797c59b7f5f0d30b4b799eb293be4973f7e13

[...]

> +          (add-after 'unpack 'fix-paths
> +            (lambda _
> +              (let ((git #$git))

This variable is unused.  If it were used, it should instead be:

  (let ((git #$(this-package-input "git")))
    …)

Ludo’.




  reply	other threads:[~2024-12-18 11:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 19:05 [bug#73993] [PATCH] gnu: git-sizer: Pin git version Greg Hogan
2024-11-29  9:40 ` Liliana Marie Prikler
2024-12-05 21:06   ` Greg Hogan
2024-12-05 21:04 ` [bug#73993] [PATCH v2 0/3] Pin git for git-sizer Greg Hogan
2024-12-05 21:04   ` [bug#73993] [PATCH v2 1/3] gnu: git-sizer: Propagate git Greg Hogan
2024-12-18 11:02     ` Ludovic Courtès
2024-12-05 21:04   ` [bug#73993] [PATCH v2 2/3] gnu: git-sizer: Use gexps Greg Hogan
2024-12-18 11:03     ` Ludovic Courtès [this message]
2024-12-05 21:04   ` [bug#73993] [PATCH v2 3/3] gnu: git-sizer: Pin git version Greg Hogan
2024-12-06 21:19     ` Liliana Marie Prikler
2024-12-09 15:30 ` [bug#73993] [PATCH v3] " Greg Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xnhmexa.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=73993@debbugs.gnu.org \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).