unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain <hako@ultrarare.space>
To: Mark H Weaver <mhw@netris.org>
Cc: "André Batista" <nandre@riseup.net>,
	"Jonathan Brielmaier" <jonathan.brielmaier@web.de>,
	74812@debbugs.gnu.org, "Clément Lassieur" <clement@lassieur.org>
Subject: [bug#74812] [PATCH v2] gnu: Add privacy-redirect-icecat.
Date: Sat, 21 Dec 2024 14:06:36 +0800	[thread overview]
Message-ID: <875xndk1sj.wl-hako@ultrarare.space> (raw)
In-Reply-To: <871py1d77j.fsf@netris.org>

Hi Mark,

On Sat, 21 Dec 2024 11:51:01 +0800,
Mark H Weaver wrote:
>
> Hi,
>
> Apologies for the late reply.
>
> Hilton Chain <hako@ultrarare.space> writes:
> > * gnu/packages/browser-extensions.scm (privacy-redirect)
> > (privacy-redirect/icecat): New variables.
>
> [...]
>
> > +(define privacy-redirect
> > +  (package
> > +    (name "privacy-redirect")
> > +    (version "1.1.49")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://github.com/SimonBrazell/privacy-redirect")
>
> If you check the git repository above, I think you'll find that it has
> not been updated in over 3 years, and that most (if not all) of the
> sites that it redirects to no longer work.  Therefore, I see no benefit
> to adding this package in its current form.
>
> There's also an additional problem: GNU IceCat comes bundled with a
> modified and updated version of this extension.  I have concerns about
> how GNU IceCat might be affected if this extremely out-of-date extension
> is installed in the user's profile.

Just tried 'guix shell icecat privacy-redirect-icecat', IceCat uses the bundled
one.

> What do you think?

How about using the source from IceCat for this package?


Thanks




  reply	other threads:[~2024-12-21  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  7:32 [bug#74812] [PATCH] gnu: Add privacy-redirect-icecat Hilton Chain
2024-12-12  7:42 ` [bug#74812] [PATCH v2] " Hilton Chain
2024-12-21  3:51   ` Mark H Weaver
2024-12-21  6:06     ` Hilton Chain [this message]
     [not found] ` <handler.74812.B.173398876915107.ack@debbugs.gnu.org>
2024-12-18 15:47   ` bug#74812: Acknowledgement ([PATCH] gnu: Add privacy-redirect-icecat.) Hilton Chain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xndk1sj.wl-hako@ultrarare.space \
    --to=hako@ultrarare.space \
    --cc=74812@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    --cc=jonathan.brielmaier@web.de \
    --cc=mhw@netris.org \
    --cc=nandre@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).