From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41347)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cwpUJ-0006j6-Lm
	for guix-patches@gnu.org; Sat, 08 Apr 2017 08:29:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cwpUE-0007gF-PI
	for guix-patches@gnu.org; Sat, 08 Apr 2017 08:29:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:38970)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cwpUE-0007fu-L1
	for guix-patches@gnu.org; Sat, 08 Apr 2017 08:29:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cwpUE-0005FE-AB
	for guix-patches@gnu.org; Sat, 08 Apr 2017 08:29:02 -0400
Subject: bug#26391: [PATCH 0/1] Patching getcap and which in torsocks
Resent-Message-ID: <handler.26391.B26391.149165451820130@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170407140511.25564-1-bavier@member.fsf.org>
Date: Sat, 08 Apr 2017 14:28:23 +0200
In-Reply-To: <20170407140511.25564-1-bavier@member.fsf.org> (Eric Bavier's
	message of "Fri, 7 Apr 2017 09:05:10 -0500")
Message-ID: <874lxzrsm0.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Eric Bavier <bavier@member.fsf.org>
Cc: 26391@debbugs.gnu.org

Hi Eric,

Eric Bavier <bavier@member.fsf.org> skribis:

> This patches references to the 'getcap' and 'which' programs in 'torsocks'
> so that users that don't have either of those packages installed in their
> profiles do not see confusing output about them missing.  Usually torsocks
> will still function in that case, but it's probably better to have them
> available.
>
> I've so far done this sort of thing for several packages with shell scrip=
ts,
> and each time I'm convinced that this method is better than declaring the
> inputs in propagated-inputs.  But I think I'd feel more sure of myself if=
 we
> had a short "Packaging shell scripts" section in the manual that outlined
> best-practices-of-the-moment.  Would that be useful?

Yes, sure.

> * gnu/packages/tor.scm (torsocks)[inputs,arguments]: New fields.

LGTM, thanks!

Ludo=E2=80=99.