From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46557)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz306-0007IA-3a
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz302-00039t-4V
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:19:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49153)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cz302-00039o-1M
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz301-0003sp-SY
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:19:01 -0400
Subject: bug#26462: [PATCH 1/2] gnu: icu4c: Fix crashes in programs using
	system ICU.
Resent-Message-ID: <handler.26462.B26462.149218312414901@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <878tn5vr4b.fsf@lassieur.org>
	<20170412105325.8099-1-clement@lassieur.org> <87d1chete8.fsf@gnu.org>
	<87bmrzm42e.fsf@lassieur.org> <87a87jm3vi.fsf@lassieur.org>
Date: Fri, 14 Apr 2017 17:18:30 +0200
In-Reply-To: <87a87jm3vi.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Fri, 14 Apr 2017 16:59:45 +0200")
Message-ID: <874lxrdnll.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 26462@debbugs.gnu.org

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Cl=C3=A9ment Lassieur <clement@lassieur.org> writes:
>
>> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>>
>>> Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:
>>>
>>>> * gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch: New fi=
le.
>>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>>> * gnu/packages/icu4c.scm (icu4c)[source]: Use it.
>>>
>>> [...]
>>>
>>>> +++ b/gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch
>>>> @@ -0,0 +1,128 @@
>>>> +Copied from upstream: http://bugs.icu-project.org/trac/changeset/3948=
4/.
>>>> +
>>>> +Paths and line endings have been adapted.
>>>
>>> Woow, good catch!
>>>
>>> 1,700 packages depend on icu4c so the update would have to go to
>>> =E2=80=98core-updates=E2=80=99, but that won=E2=80=99t be merged until =
several weeks.
>>>
>>> For =E2=80=98master=E2=80=99, in the meantime, I see two solutions:
>>>
>>>   1. If the bug only affects specific applications, we could add an
>>>      icu4c variant and use that only where needed (icecat, 0ad, etc.).
>>>
>>>   2. If the bug manifests itself pervasively we could graft it in
>>>      =E2=80=98master=E2=80=99 (I guess it=E2=80=99s ABI-compatible, rig=
ht?).
>>>
>>> Thoughts?
>>
>> I prefer the second solution, in case the bug appears in other
>> applications as well, and I think it is ABI-compatible.  I just sent the
>> patch for the graft in master.  I'll do the patch for core-updates
>> later, when master is merged into it.
>
> But I might be wrong :)  If you think the first solution is better,
> don't hesitate to tell me, I'll do another patch.

No no, I trust you!  I mean, making a graft in master is the safest
approach anyway.

Ludo=E2=80=99.