From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czRQc-0004nc-Fa
	for guix-patches@gnu.org; Sat, 15 Apr 2017 13:24:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czRQY-0000cq-H9
	for guix-patches@gnu.org; Sat, 15 Apr 2017 13:24:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51053)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1czRQY-0000cU-Cd
	for guix-patches@gnu.org; Sat, 15 Apr 2017 13:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1czRQY-0007j1-3h
	for guix-patches@gnu.org; Sat, 15 Apr 2017 13:24:02 -0400
Subject: bug#26339: [PATCH 07/18] system: Add bootloader type.
Resent-Message-ID: <handler.26339.B26339.149227700229649@debbugs.gnu.org>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-7-m.othacehe@gmail.com>
	<20170415182634.4e2f9c68@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170415182634.4e2f9c68@scratchpost.org>
Date: Sat, 15 Apr 2017 19:23:13 +0200
Message-ID: <874lxpinzy.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26339@debbugs.gnu.org


> Oh, so that's how.  I think it would be nice-to-have if the user could also override the bootloader package used.

The user could already write :

--8<---------------cut here---------------start------------->8---
(bootloader-configuration
 (inherit %grub-configuration)
 (bootloader my-grub))
--8<---------------cut here---------------end--------------->8---

Or am I wrong here ?

>
>> -   (install-procedure install-syslinux)))
>
> Wait, so install-syslinux wouldn't need to be exported from this module at all, right?
>
> Still nice that the user can use it - though is it worth exposing the installers?

I'm not sure here, maybe not exposing installers would be better here.

>
> Otherwise LGTM!

Thanks,

Mathieu