From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 26669@debbugs.gnu.org
Subject: bug#26669: [PATCH 1/7] gnu: Add cdrtools.
Date: Wed, 26 Apr 2017 18:59:53 +0200 [thread overview]
Message-ID: <874lxbdrzq.fsf@gmail.com> (raw)
In-Reply-To: <20170426.180534.1677459693482729603.post@thomasdanckaert.be>
Hi Thomas,
Thanks for the patches !
Without going into details, it seems to me that you have indentation
issues in this serie.
> +(define-public cdrtools
> + (package
From here indentation is broken.
> + (name "cdrtools")
> + (version "3.01")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://sourceforge/cdrtools/cdrtools-" version ".tar.bz2"))
> + (sha256
> + (base32
> + "03w6ypsmwwy4d7vh6zgwpc60v541vc5ywp8bdb758hbc4yv2wa7d"))
> + (patches (search-patches "cdrtools-3.01-mkisofs-isoinfo.patch"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("linux-headers" ,linux-libre-headers)))
> + (native-inputs
> + `(("coreutils" ,coreutils)))
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'set-linux-headers
> + (lambda _
> + (substitute* "autoconf/configure"
> + (("/usr/src/linux")
> + (assoc-ref %build-inputs "linux-headers")))
> + #t))
> + (add-before 'build 'substitute-dirs
> + (lambda _
> + (substitute* (append (find-files "DEFAULTS" "^Defaults\\.")
> + (find-files "DEFAULTS_ENG" "^Defaults\\.")
Please keep all lines in *.scm files to 80 columns or less.
> + (find-files "TEMPLATES" "^Defaults\\."))
> + (("/opt/schily") (assoc-ref %outputs "out")))
> + #t))
Thanks,
Mathieu
next prev parent reply other threads:[~2017-04-26 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 16:05 bug#26669: [PATCH 1/7] gnu: Add cdrtools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools Thomas Danckaert
2017-04-26 16:30 ` bug#26669: [PATCH 3/7] gnu: brasero: Embed growisofs store item Thomas Danckaert
2017-04-28 5:54 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 4/7] gnu: Add dvdauthor Thomas Danckaert
2017-04-27 18:50 ` Danny Milosavljevic
2017-04-26 16:30 ` bug#26669: [PATCH 5/7] gnu: Add wxwidgets-3.1 Thomas Danckaert
2017-05-03 13:00 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 6/7] gnu: Add wxsvg Thomas Danckaert
2017-05-03 13:02 ` Ludovic Courtès
2017-04-26 16:30 ` bug#26669: [PATCH 7/7] gnu: Add dvdstyler Thomas Danckaert
2017-05-03 13:04 ` Ludovic Courtès
2017-05-10 7:48 ` bug#26669: [PATCH 1/7] gnu: Add cdrtools Thomas Danckaert
2017-05-10 11:55 ` Ludovic Courtès
2017-04-26 17:15 ` bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools Danny Milosavljevic
2017-04-26 16:59 ` Mathieu Othacehe [this message]
2017-05-03 12:59 ` bug#26669: [PATCH 1/7] gnu: Add cdrtools Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lxbdrzq.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=26669@debbugs.gnu.org \
--cc=post@thomasdanckaert.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).