From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5fN1-0004PB-23 for guix-patches@gnu.org; Tue, 02 May 2017 17:30:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5fMx-0001QR-Qn for guix-patches@gnu.org; Tue, 02 May 2017 17:30:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5fMx-0001QL-O3 for guix-patches@gnu.org; Tue, 02 May 2017 17:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5fMx-00056O-Hw for guix-patches@gnu.org; Tue, 02 May 2017 17:30:03 -0400 Subject: bug#26747: [PATCH] gnu: Avoid circular dependencies by perl license Resent-To: guix-patches@gnu.org Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170502174648.6811d398@mykolab.ch> Date: Tue, 02 May 2017 23:29:22 +0200 In-Reply-To: <20170502174648.6811d398@mykolab.ch> (petter@mykolab.ch's message of "Tue, 2 May 2017 17:46:48 +0200") Message-ID: <874lx30wy5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Petter Cc: 26747-done@debbugs.gnu.org Hello Petter, Petter skribis: > I've never been able to add modules to perl.scm. Today civodul showed me = that > it's because "(package-license perl)" in at least a few other files were = causing > circular dependencies with perl.scm. I don't know how to figure out exact= ly > which were causing this for perl.scm, so I've changed this in every file = with > this (except perl.scm) to have "license:perl-license" instead. (Fixing ju= st > what I'd have needed seems like leaving a problem for the next person any= way.) > > With this patch I can add modules to perl.scm :) Nice. :-) > P.S. The error I got was the same as I get with most of my errors: "unkn= own > package". At this point I'm beginning to interpret "unknown package" as > "something failed". I find it that unhelpful, but more misleading. Maybe = we > should discuss this. Yeah, it=E2=80=99s tricky. In this case, what happened is that it failed to load (gnu packages perl). Thus, the best it could do would be to print the infamous =E2=80=9Cno code for module (gnu packages perl)=E2=80=9D, whic= h wouldn=E2=80=99t help. What would help would be detection circular dependencies due to top-level references in the first place. > From 7c39ae8fe3b956eb291fd1bc5ba86297cefb67b8 Mon Sep 17 00:00:00 2001 > From: Petter > Date: Tue, 2 May 2017 16:57:52 +0200 > Subject: [PATCH] gnu: Avoid circular dependencies by perl license > > * guix/licenses.scm: New variable. > * gnu/packages/bioinformatics.scm: Change (package-license perl) to perl-= license. > * gnu/packages/compression.scm: Same. > * gnu/packages/databases.scm: Same. > * gnu/packages/gd.scm: Same. > * gnu/packages/language.scm: Same. > * gnu/packages/libevent.scm: Same. > * gnu/packages/mail.scm: Same. > * gnu/packages/messaging.scm: Same. > * gnu/packages/ncurses.scm: Same. > * gnu/packages/networking.scm: Same. > * gnu/packages/photo.scm: Same. > * gnu/packages/tcl.scm: Same. > * gnu/packages/tex.scm: Same. > * gnu/packages/tls.scm: Same. > * gnu/packages/web.scm: Same. > * gnu/packages/wm.scm: Same. > * gnu/packages/xml.scm: Same. > * gnu/packages/xorg.scm: Same. > * gnu/packages/zip.scm: Same. [...] > +(define perl-license gpl1+) I added a comment here and committed. Thank you! Ludo=E2=80=99.