From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9tcx-0001rg-FB
	for guix-patches@gnu.org; Sun, 14 May 2017 09:32:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9tcw-0000Qk-P7
	for guix-patches@gnu.org; Sun, 14 May 2017 09:32:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:41024)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d9tcw-0000QX-LC
	for guix-patches@gnu.org; Sun, 14 May 2017 09:32:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9tcw-00078g-FB
	for guix-patches@gnu.org; Sun, 14 May 2017 09:32:02 -0400
Subject: bug#26339: [PATCH v4 4/7] scripts: system: Adapt "reconfigure" to new
	bootloader API.
Resent-Message-ID: <handler.26339.B26339.149476869427404@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170514074803.25556-1-m.othacehe@gmail.com>
	<20170514074803.25556-5-m.othacehe@gmail.com>
Date: Sun, 14 May 2017 15:31:20 +0200
In-Reply-To: <20170514074803.25556-5-m.othacehe@gmail.com> (Mathieu Othacehe's
	message of "Sun, 14 May 2017 09:48:00 +0200")
Message-ID: <874lwnwonr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26339@debbugs.gnu.org

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * guix/scripts/system.scm (install-grub*): Rename to install-bootloader. =
Use
>   keys to pass arguments. Pass a new argument, "installer.drv" which is
>   a script in store dealing with bootloader-specific install actions.
>   Also call "install-boot-config" to install the bootloader config file.
 ^^
Extra space.

> (install-bootloader-derivation): New procedure. It returns a derivation t=
hat
> builds a file containing "install-procedure" gexp.
> (perform-action): Build install-proc derivation and call install-bootload=
er
> with the resulting file. Stop adding GRUB to PATH as bootloaders are call=
ed in
> install-proc with direct store paths.

[...]

> +(define* (install-bootloader installer.drv

Please avoid dots in identifiers.

Otherwise LGTM!

Ludo=E2=80=99.