From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dB8fl-0004Td-BB
	for guix-patches@gnu.org; Wed, 17 May 2017 19:48:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dB8fi-00075K-8K
	for guix-patches@gnu.org; Wed, 17 May 2017 19:48:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48814)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dB8fi-000750-54
	for guix-patches@gnu.org; Wed, 17 May 2017 19:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dB8fh-0002xe-Pc
	for guix-patches@gnu.org; Wed, 17 May 2017 19:48:01 -0400
Subject: bug#26934: Re: bug#26934: [PATCH 1/3] gnu: video: add libzen
References: <20170515025701.2492-1-doubleplusgood23@gmail.com>
In-Reply-To: <20170515025701.2492-1-doubleplusgood23@gmail.com>
Resent-Message-ID: <handler.26934.B26934.149506487711373@debbugs.gnu.org>
Date: Wed, 17 May 2017 19:47:47 -0400
Message-Id: <874lwjt598.fsf@gmail.com>
From: doubleplusgood23@gmail.com (Ethan R. Jones)
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: ludo@gnu.org
Cc: 26934@debbugs.gnu.org

<#secure method=pgp mode=sign>
Thanks for the response.
>> ---
>>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)

>Could you provide ChangeLog-style commit logs?  See ‘git log’ for
>examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html>.

So I should independently `git add --patch` each addition, then do a multi-line
`git commit` like so:

    gnu: foo: Update to 1.0.
    
    * gnu/packages/foo.scm (foo): Update to 1.0
    * gnu/packages/foo.scm (libbar): New shared library.

>Could you squeeze that on one or two lines?

Is there a style on when to squeeze and when to not?

>Please double-check that this is needed.

Yup, all packages lack a proper configure script.

>Could you improve the synopsis and description

Do you have any ideas of what to add? I wasn't sure where to start
myself

Thanks!

dpg