unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Muriithi Frederick Muriuki <fredmanglis@gmail.com>,
	27558@debbugs.gnu.org
Subject: [bug#27558] [PATCH] gnu: Add python-ruamel.yaml
Date: Tue, 11 Jul 2017 21:21:38 +0200	[thread overview]
Message-ID: <874luilqyl.fsf@fastmail.com> (raw)
In-Reply-To: <20170703034703.9668-1-fredmanglis@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Muriithi Frederick Muriuki <fredmanglis@gmail.com> writes:

> * gnu/packages/python.scm (python-ruamel.yaml, python2-ruamel.yaml):
>   New variables.

[...]

> +(define-public python-ruamel.yaml
> +  (package
> +    (name "python-ruamel.yaml")
> +    (version "0.15.16")

0.15.18 is out already, sorry for the slow review! Can you try updating
to it?

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "ruamel.yaml" version))
> +       (sha256
> +        (base32
> +         "0yx1a1yqgm1phrmyvqzag5jwivn25ndlnwh2mgwgr7m8skn2h045"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(;; Tests fail with message:
> +       ;; ImportError: Failed to import test module: .ruamel
> +       ;; but the directory .ruamel exists in the environment
> +       ;; left when the package is built with --keep-failed
> +       #:tests? #f))

'python setup.py test' does not work for all packages and may return
bogus errors like these. Often you can find hints for how upstream runs
their tests in "tox.ini", or CI configuration files like ".travis.yml".

tox.ini in this case runs "bash -c 'pytest _test/test_*.py'". Can you
try replacing the check phase with a phase that invokes this command?

Apart from that looks good!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-07-11 19:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  3:47 [bug#27558] [PATCH] gnu: Add python-ruamel.yaml Muriithi Frederick Muriuki
2017-07-11 19:21 ` Marius Bakke [this message]
2017-07-11 23:17 ` Muriithi Frederick Muriuki
2017-07-13 19:47   ` Marius Bakke
2017-07-13 19:53     ` Frederick Muriithi
2017-07-14 13:22 ` Muriithi Frederick Muriuki
2017-07-16 20:38   ` Marius Bakke
2017-07-16 20:39     ` Frederick Muriithi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874luilqyl.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=27558@debbugs.gnu.org \
    --cc=fredmanglis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).