unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Dave Love <fx@gnu.org>
To: 27848@debbugs.gnu.org
Subject: [bug#27848] guix: build-system: gnu: Avoid warnings from "libtool finish"
Date: Thu, 27 Jul 2017 15:40:33 +0100	[thread overview]
Message-ID: <874ltyhrj2.fsf@i-ulialbion.it.manchester.ac.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

The "ldconfig not found" warnings confused me, and caused a bug report
previously.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-guix-build-system-gnu-Avoid-warnings-from-libtool-fi.patch --]
[-- Type: text/x-diff, Size: 1476 bytes --]

From d6f42badc39679dd36ea8f582140a7d63316d101 Mon Sep 17 00:00:00 2001
From: Dave Love <fx@gnu.org>
Date: Thu, 27 Jul 2017 15:35:53 +0100
Subject: [PATCH] guix: build-system: gnu: Avoid warnings from "libtool
 finish".

* guix/build/gnu-build-system.scm (configure): Avoid warnings from
libtool invoking ldconfig.
---
 guix/build/gnu-build-system.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index 1786e2e3c..508699497 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -271,9 +271,15 @@ makefiles."
     ;; Call `configure' with a relative path.  Otherwise, GCC's build system
     ;; (for instance) records absolute source file names, which typically
     ;; contain the hash part of the `.drv' file, leading to a reference leak.
-    (zero? (apply system* bash
-                  (string-append srcdir "/configure")
-                  flags))))
+    (and (zero? (apply system* bash
+                       (string-append srcdir "/configure")
+                       flags))
+         ;; Avoid warnings about from "libtool finish" about not finding
+         ;; ldconfig.
+         (if (file-exists? "libtool")
+             (begin (substitute* "libtool" (("ldconfig") ":"))
+                    #t)
+             #t))))
 
 (define* (build #:key (make-flags '()) (parallel-build? #t)
                 #:allow-other-keys)
-- 
2.11.0


             reply	other threads:[~2017-07-27 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 14:40 Dave Love [this message]
2017-07-31 15:28 ` [bug#27848] guix: build-system: gnu: Avoid warnings from "libtool finish" Ludovic Courtès
2017-07-31 18:17   ` Dave Love
2017-07-31 19:26     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ltyhrj2.fsf@i-ulialbion.it.manchester.ac.uk \
    --to=fx@gnu.org \
    --cc=27848@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).