From: ludo@gnu.org (Ludovic Courtès)
To: "Z. Ren" <zren@dlut.edu.cn>
Cc: 28016-done@debbugs.gnu.org
Subject: bug#28016: [PATCH] Reproducible issue for libjpeg-turbo
Date: Tue, 22 Aug 2017 14:53:28 +0200 [thread overview]
Message-ID: <874lsz7ohj.fsf@gnu.org> (raw)
In-Reply-To: <2578d464.17dbf.15de9349b8f.Coremail.zren@dlut.edu.cn> (Z. Ren's message of "Wed, 16 Aug 2017 12:02:05 +0800 (GMT+08:00)")
Hi,
"Z. Ren" <zren@dlut.edu.cn> skribis:
> There was a typo (redundant brackets around SOURCE_DATE_EPOCH) in the previous submitted patch, sorry that I'm not very familiar with the Guix system. I attach the modified patch. Following the suggestion of Leo (https://lists.gnu.org/archive/html/help-guix/2017-08/msg00053.html Thanks for the suggestion), I investigate the source code of libjpeg-turbo. It appears that the upstream package supports the argument --with-build-date. Maybe this is more suitable for fixing the unreproducible problem?
>
> Based on this idea, I tried setting configure-flags with SOURCE_DATE_EPOCH. Unfortunately, the flag is not assigned properly with the following snippet:
>
> #:configure-flags
> (list (string-append "--with-build-date="
> (date->string
> (time-utc->date
> (make-time time-utc 0
> (string->number (getenv "SOURCE_DATE_EPOCH")))) "'~Y~m~d'")))
>
> Is it because the environmental variable SOURCE_DATE_EPOCH is not yet
> set at the time of #:configure-flags?
Yes, that’s correct.
I’ve pushed a simple version that does:
#:configure-flags (list "--with-build-date=1970-01-01")
It’s good enough because we set SOURCE_DATE_EPOCH to 0 anyway.
Thank you for working on reproducibility issues!
Ludo’.
prev parent reply other threads:[~2017-08-22 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 7:32 [bug#28016] [PATCH] Reproducible issue for libjpeg-turbo Z. Ren
2017-08-16 4:02 ` Z. Ren
2017-08-22 12:53 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lsz7ohj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28016-done@debbugs.gnu.org \
--cc=zren@dlut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).