From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHteb-0007MD-Eg
	for guix-patches@gnu.org; Thu, 23 Nov 2017 10:43:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHteY-0002vL-2T
	for guix-patches@gnu.org; Thu, 23 Nov 2017 10:43:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45356)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eHteX-0002vD-W0
	for guix-patches@gnu.org; Thu, 23 Nov 2017 10:43:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eHteX-0006UW-L5
	for guix-patches@gnu.org; Thu, 23 Nov 2017 10:43:01 -0500
Subject: [bug#29406] [PATCH core-updates]: Add selected upstream fixes for
	glibc 2.26.
Resent-Message-ID: <handler.29406.B29406.151145175424916@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87mv3eove6.fsf@fastmail.com>
Date: Thu, 23 Nov 2017 16:42:22 +0100
In-Reply-To: <87mv3eove6.fsf@fastmail.com> (Marius Bakke's message of "Wed, 22
	Nov 2017 22:28:49 +0100")
Message-ID: <874lplvw69.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29406@debbugs.gnu.org

Hello!

Marius Bakke <mbakke@fastmail.com> skribis:

> I discovered that 'icu4c' failed to build for x86_64 on 'core-updates'.
> After some investigation, it turns out to be a problem with <math.h> in
> C++ mode, due to its usage of C-only builtins (in the 2.26 release).

[...]

> So I wonder if we should simply pick everything from this branch,
> instead of only the few that fixes immediately visible problems.
> Thoughts?

Cherry-picking like you did sounds reasonable to me.

That said, as discussed on IRC, I think that it=E2=80=99s up to upstream to=
 tell
us what code we should be building, and a simple way to do that is by
making a bug-fix release.

> From 7121dc7ed24e97080154794fb14ae4078a3451f7 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Wed, 22 Nov 2017 22:26:31 +0100
> Subject: [PATCH] gnu: glibc: Add selected fixes from upstream stable bran=
ch.
>
> This backports a small subset of
> <https://sourceware.org/git/?p=3Dglibc.git;a=3Dshortlog;h=3Drefs/heads/re=
lease/2.26/master>.
>
> * gnu/packages/patches/glibc-2.26-cpp-fixes.patch,
> gnu/packages/patches/glibc-2.26-ifunc-resolver-longjmp.patch,
> gnu/packages/patches/glibc-2.26-resolver-fixes.patch: New files.
> * gnu/local.mk (dist_patch_DATA): Register them.
> * gnu/packages/base.scm (glibc/linux)[source](patches): Use them.

Great that you created one patch for each category of bug.

LGTM!

After applying, you can restart an evaluation of =E2=80=98core-updates=E2=
=80=99.

Thanks,
Ludo=E2=80=99.