From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLdFw-0000nE-Gt for guix-patches@gnu.org; Sun, 03 Dec 2017 18:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLdFu-0003UE-35 for guix-patches@gnu.org; Sun, 03 Dec 2017 18:01:04 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLdFt-0003U3-VY for guix-patches@gnu.org; Sun, 03 Dec 2017 18:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLdFt-0005un-Kn for guix-patches@gnu.org; Sun, 03 Dec 2017 18:01:01 -0500 Subject: [bug#29528] Add blacknurse Resent-Message-ID: References: <20171130194227.bpe4l2ccvcrr5spb@abyayala> From: Ricardo Wurmus In-reply-to: <20171130194227.bpe4l2ccvcrr5spb@abyayala> Date: Mon, 04 Dec 2017 00:00:08 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <874lp74dtz.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 29528@debbugs.gnu.org Hi ng0, > +(define-public blacknurse > + (let* ((commit "d2a2b23544295844714ebf8d2d78af37fe5770c9") > + (revision "1")) > + (package > + (name "blacknurse") > + (version (string-append "0.0.0-" revision "." (string-take commit = 7))) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jedisct1/blacknurse") > + (commit commit))) > + (file-name (string-append name "-" version)) This should be =E2=80=9C(file-name (string-append name "-" version "-checko= ut"))=E2=80=9D. > + (sha256 > + (base32 > + "1w7zmcrnrs4p4naj3i6h1wcmd56dgrfd7myx0ljhw162sg0134nz")))) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags (list "CC=3Dgcc") > + #:tests? #f ; No tests > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ; No configure script > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (install-file "blacknurse" bin))))))) This should end on #t. > + (home-page "https://github.com/jedisct1/blacknurse") > + (synopsis "Proof of Concept for the Blacknurse attack") > + (description > + "Simple Proof of Concept for the Blacknurse attack. > +Blacknurse is a low bandwidth ICMP attack that is capable of doing denia= l > +of service to well known firewalls.") The first fragment is not a full sentence. Looking at this package I wonder why it should be part of Guix as it is merely malware. I don=E2=80=99t see any reason why this should be installa= ble through Guix. We are not in the habit of providing packages for exploits. Putting it in =E2=80=9Cnetworking=E2=80=9D makes it seem like th= is would be a useful networking application, but it really is not. It just demonstrates a bug in networked devices. @Ludo: what do you think? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net