From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQheF-000686-0r
	for guix-patches@gnu.org; Sun, 17 Dec 2017 17:43:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQheA-000423-8f
	for guix-patches@gnu.org; Sun, 17 Dec 2017 17:43:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58992)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eQheA-00041Y-1Z
	for guix-patches@gnu.org; Sun, 17 Dec 2017 17:43:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eQhe9-0008Eb-L8
	for guix-patches@gnu.org; Sun, 17 Dec 2017 17:43:01 -0500
Subject: [bug#29359] [PATCH 02/31] gnu: Add java-jsoup.
Resent-Message-ID: <handler.29359.B29359.151355057731643@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-2-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171119175805.902-2-julien@lepiller.eu>
Date: Sun, 17 Dec 2017 23:42:21 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <874lopnfhu.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29359@debbugs.gnu.org


Hi Julien,

> * gnu/packages/java.scm (java-jsoup): New variable.

How about adding it to web.scm instead?

[=E2=80=A6]

> +(define-public java-jsoup
> +  (package
> +    (name "java-jsoup")
> +    (version "1.10.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/jhy/jsoup/archive/=
jsoup-"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

I don=E2=80=99t think this is necessary.

> +    (native-inputs
> +     `(("java-junit" ,java-junit)
> +       ("java-hamcrest-core" ,java-hamcrest-core)
> +       ("java-gson" ,java-gson)))

Is gson really just used at build time?

> +    (home-page "https://jsoup.org")
> +    (synopsis "HTML Parser")

s/Parser/parser/

> +    (description "Jsoup is a Java library for working with real-world HT=
ML.  It
> +provides a very convenient API for extracting and manipulating data, usi=
ng the
> +best of DOM, CSS, and jquery-like methods.")

=E2=80=9CjQuery=E2=80=9D.

--=20
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net