[bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.

[bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.

[Roel Janssen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-bash-Don-t-specify-default-configuration-filenam.patch --]
[-- Type: text/x-patch, Size: 1170 bytes --]

From 6111b46f82a00560fa50f8860a4e9fd6b19fd0f1 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 7 Feb 2018 12:29:22 +0100
Subject: [PATCH] gnu: bash: Don't specify default configuration filenames.

* gnu/packages/bash.scm (bash): Remove SYS_BASHRC and SYS_BASH_LOGOUT.
---
 gnu/packages/bash.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index b8b0ae58f..59c3f6f10 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -92,9 +92,7 @@ number/base32-hash tuples, directly usable in the 'patch-series' form."
           1))
 
 (define-public bash
-  (let* ((cppflags (string-join '("-DSYS_BASHRC='\"/etc/bashrc\"'"
-                                  "-DSYS_BASH_LOGOUT='\"/etc/bash_logout\"'"
-                                  "-DDEFAULT_PATH_VALUE='\"/no-such-path\"'"
+  (let* ((cppflags (string-join '("-DDEFAULT_PATH_VALUE='\"/no-such-path\"'"
                                   "-DSTANDARD_UTILS_PATH='\"/no-such-path\"'"
                                   "-DNON_INTERACTIVE_LOGIN_SHELLS"
                                   "-DSSH_SOURCE_BASHRC")
-- 
2.16.1


[-- Attachment #2: Type: text/plain, Size: 735 bytes --]

Dear guix,

In bug #29337 I reported a “problem” with our Bash package:  It reads
/etc/bashrc even when it shouldn't, according to its own documentation.
I also compared the behavior of Bash on CentOS to that of Bash on Guix
with the following test:

> On CentOS 7, the following happens (yes, I added the echo-statement to
> /etc/bashrc on CentOS as well):
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Goodbye, world
>
> On GuixSD:
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Hello, world
> Goodbye, world

I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
to core-updates now, or should I wait for the next core-updates cycle?

Thanks!

Kind regards,
Roel Janssen

[bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.

[Ludovic Courtès]

Hi,

Roel Janssen <roel@gnu.org> skribis:

> In bug #29337 I reported a “problem” with our Bash package:  It reads
> /etc/bashrc even when it shouldn't, according to its own documentation.
> I also compared the behavior of Bash on CentOS to that of Bash on Guix
> with the following test:
>
>> On CentOS 7, the following happens (yes, I added the echo-statement to
>> /etc/bashrc on CentOS as well):
>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>> Goodbye, world
>>
>> On GuixSD:
>> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
>> Hello, world
>> Goodbye, world
>
> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
> to core-updates now, or should I wait for the next core-updates cycle?

Not now, because it’s still not merged (but you can help! :-)), but
definitely soonish, hopefully within a few days.

(I think that’s what we agreed on
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29337#28>.)

Thank you!

Ludo’.

[bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
> to core-updates now, or should I wait for the next core-updates cycle?

Now’s a good time to push to ‘core-updates’!

TIA,
Ludo’.

[bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.

[Roel Janssen]

Ludovic Courtès <ludo@gnu.org> writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> I attached the proposed patch (removing -DSYS_BASHRC).  May I push this
>> to core-updates now, or should I wait for the next core-updates cycle?
>
> Now’s a good time to push to ‘core-updates’!
>
> TIA,
> Ludo’.

Thanks!  I applied it in 1382bde93.

Kind regards,
Roel Janssen

bug#30379: Status: [PATCH] gnu: bash: Don't specify default configuration filenames.

[宋文武]

Already landed in master, closing :-)