From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqOH-0006OH-C5
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:03:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqOE-0002oT-Ql
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:03:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:50883)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1frqOE-0002o3-Ey
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:03:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1frqOE-00020r-4l
	for guix-patches@gnu.org; Mon, 20 Aug 2018 16:03:02 -0400
Subject: [bug#32346] [PATCH 1/6] services: tor: Add a system test.
Resent-Message-ID: <handler.32346.B32346.15347953797729@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180802064520.20273-1-cmmarusich@gmail.com>
	<20180802065159.20413-1-cmmarusich@gmail.com>
Date: Mon, 20 Aug 2018 22:02:49 +0200
In-Reply-To: <20180802065159.20413-1-cmmarusich@gmail.com> (Chris Marusich's
	message of "Wed, 1 Aug 2018 23:51:54 -0700")
Message-ID: <874lfoerh2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 32346@debbugs.gnu.org

Hi Chris,

Chris Marusich <cmmarusich@gmail.com> skribis:

> * gnu/services/networking.scm (tor-configuration->torrc): Set PidFile to
> /var/run/tor/tor.pid in the base torrc configuration.
> (tor-shepherd-service) <start>: Call make-forkexec-constructor/container =
with
> a new #:pid-file argument to tell Shepherd where to find the PID file.  A=
dd a
> a new <file-system-mapping> to its existing #:mappings argument to share
> /var/run/tor with the the container.
> (tor-hidden-services-activation): Update docstring.  Create /var/run/tor =
and
> set its permissions so only the tor user can access it.
> * gnu/tests/networking.scm (%test-tor, %tor-os): New variables.
> (run-tor-test): New procedure.

LGTM!  Great work.

> +      ;; Allow TOR to write its PID file.

Nitpick: I think the maintainers no longer consider the name an acronym
and write it as =E2=80=9CTor=E2=80=9D, not =E2=80=9CTOR=E2=80=9D.

Thanks,
Ludo=E2=80=99.