From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g8UIn-00017J-QD
	for guix-patches@gnu.org; Fri, 05 Oct 2018 13:54:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g8U8w-0000bD-N6
	for guix-patches@gnu.org; Fri, 05 Oct 2018 13:44:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33923)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1g8U8w-0000ar-If
	for guix-patches@gnu.org; Fri, 05 Oct 2018 13:44:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1g8U8w-0004Mh-C7
	for guix-patches@gnu.org; Fri, 05 Oct 2018 13:44:02 -0400
Subject: [bug#32802] [PATCH] gnu: gnucash: Update to 3.2.
Resent-Message-ID: <handler.32802.B32802.153876143016750@debbugs.gnu.org>
From: Kei Kebreau <kkebreau@posteo.net>
References: <20180922052514.25030-1-kkebreau@posteo.net>
	<87a7o7w07f.fsf@gnu.org>
Date: Fri, 05 Oct 2018 13:43:38 -0400
In-Reply-To: <87a7o7w07f.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Mon, 24 Sep 2018 14:26:28 +0200")
Message-ID: <874le08f1x.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 32802@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/patches/gnucash-disable-failing-tests.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Register it.
>> * gnu/packages/gnucash.scm (gnucash): Update to 3.2.
>> [source]: Add patch.
>> [arguments]: Add 'glib-or-gtk-compile-schemas' and 'glib-or-gtk-wrap' ph=
ases..
>
> [...]
>
>> --- /dev/null
>> +++ b/gnu/packages/patches/gnucash-disable-failing-tests.patch
>> @@ -0,0 +1,39 @@
>> +diff -ur gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt
>> gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt
>> +--- gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt
>> 2018-09-16 22:07:42.445865806 -0400
>> ++++ gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt
>> 2018-09-16 22:08:29.246608711 -0400
>
> Please add couple of lines at the top explaining what the patch does and
> roughly what the problem is with these tests.
>

Done!

>> +-gnc_add_test(test-gnc-timezone "${test_gnc_timezone_SOURCES}"
>> +-  gtest_engine_INCLUDES gtest_old_engine_LIBS)
>
> Could it be that you need =E2=80=98tzdata-for-tests=E2=80=99 as an input,=
 with TZDIR set
> accordingly?
>

Yes, this fixed the "test-real-data" test.

> Otherwise LGTM, thanks!
>
> Ludo=E2=80=99.

Pushed to master with the newly-released GnuCash 3.3!