From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVcfG-0003nM-W1
	for guix-patches@gnu.org; Sat, 08 Dec 2018 08:29:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVcfG-0005Bw-74
	for guix-patches@gnu.org; Sat, 08 Dec 2018 08:29:02 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33507)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gVcfG-0005Bo-3G
	for guix-patches@gnu.org; Sat, 08 Dec 2018 08:29:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVcfF-0008QS-VU
	for guix-patches@gnu.org; Sat, 08 Dec 2018 08:29:02 -0500
Subject: [bug#33395] [PATCH 1/2] gnu: Add liblcf.
Resent-Message-ID: <handler.33395.B33395.154427572632360@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20181115111223.1982-1-iyzsong@member.fsf.org>
	<871s76bxa4.fsf@gnu.org> <87zhtgelv9.fsf@member.fsf.org>
Date: Sat, 08 Dec 2018 14:28:36 +0100
In-Reply-To: <87zhtgelv9.fsf@member.fsf.org>
	("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s message of "Sat,
	08 Dec 2018 11:30:18 +0800")
Message-ID: <874lbo9mgr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Cc: 33395@debbugs.gnu.org

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> Hello =E5=AE=8B=E6=96=87=E6=AD=A6!
>>
>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:
>>
>>> * gnu/packages/easyrpg.scm: New file.
>>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>>
>> Should it go to game-development.scm?
>
> Not sure, but I'd prefer it go into the same file with 'easyrpg-player',
> which IMO dosen't belong into 'games.scm'...

OK, sounds good.

>>
>>> +    (synopsis "Library to handle RPG Maker 2000 and 2003 game data")
>>> +    (description
>>> +     "@code{liblcf} is a library to handle RPG Maker 2000 and 2003 gam=
e data.
>>> +It can read and write LCF and XML files.")
>>> +    ;; It bundles Boost Preprocessor Cat and Stringize (boost-1.0) and=
 a copy
>>> +    ;; of inih (bsd-3).
>>> +    (license license:expat)))
>>
>> Could these things be unbundled?  If not, could you leave a comment
>> possibly with a TODO?
>
> Ok, how about:
>
>     ;; It includes a copy of Boost Preprocessor Cat and Stringize (boost-=
1.0):
>     ;;   src/boost/preprocessor/config.hpp
>     ;;   src/boost/preprocessor/cat.hpp
>     ;;   src/boost/preprocessor/stringize.hpp
>     ;; and a copy of inih (bsd-3):
>     ;;   src/ini.h
>     ;;   src/ini.cpp
>     ;;   src/initreader.cpp
>     ;; TODO: Unbundle them.

LGTM!

Hopefully at least the =E2=80=9Cini=E2=80=9D part won=E2=80=99t be difficul=
t to unbundle.

Thanks,
Ludo=E2=80=99.