From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, "Amin Bandali" <bandali@gnu.org>
Cc: 33764@debbugs.gnu.org
Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings.
Date: Fri, 21 Dec 2018 21:40:47 +0100 [thread overview]
Message-ID: <874lb6aa0g.fsf@fastmail.com> (raw)
In-Reply-To: <87k1k2olth.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hello!
>
> Amin Bandali <bandali@gnu.org> skribis:
>
>> On 2018-12-17 9:29 AM, Efraim Flashner wrote:
>>> On Sun, Dec 16, 2018 at 04:18:16PM +0100, Ludovic Courtès wrote:
>
> [...]
>
>>>> > +(define-public python2-z3
>>>> > + (package (inherit python-z3)
>>>>
>>>> This definition cannot be in python.scm; it must be in the same file as
>>>> ‘z3’ or we can get “unbound variable” errors while loading either of
>>>> these two modules.
>>
>> Oh I see. If we choose to keep it (add it), I’ll move it to maths.scm.
>>
>>>> Also, as we’re approaching end-of-life upstream for Python 2.x, we now
>>>> avoid creating “python2-” packages, unless we cannot avoid it for some
>>>> reason. Do you think we could do without this “python2-z3” package?
>>>>
>>>
>>> Currently our z3 package builds python2 bindings
>>
>> What Efraim said. Since the current z3 provides python2 bindings, I
>> thought I would preserve that option by adding a python2-z3 in case
>> anyone wants to continue to use the python2 bindings.
>>
>> I’m Cc’ing Marius who’s one of the recent committers to the z3 package
>> definition. Marius, any thoughts on whether we should keep the python2
>> bindings around or do away with them?
>
> Marius, WDYT?
Hello!
I don't actually know z3 at all, I just updated it to fix the build on
core-updates :-)
In any case dropping python2 bindings seems sensible, seeing as Python 2
is EOL in a year[1]. So please go ahead, thank you Amin!
[1]: https://www.python.org/dev/peps/pep-0373/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-12-21 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 4:05 [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings Amin Bandali
2018-12-16 15:18 ` Ludovic Courtès
2018-12-17 7:29 ` Efraim Flashner
2018-12-17 14:34 ` Amin Bandali
2018-12-21 17:02 ` Ludovic Courtès
2018-12-21 20:40 ` Marius Bakke [this message]
2018-12-21 23:41 ` Amin Bandali
2018-12-22 15:20 ` Amin Bandali
2018-12-23 17:33 ` bug#33764: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lb6aa0g.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=33764@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).