From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
Cc: 34811@debbugs.gnu.org
Subject: [bug#34811] Make package name regexes case-insensitive
Date: Fri, 15 Mar 2019 23:11:11 +0100 [thread overview]
Message-ID: <874l833i0w.fsf@gnu.org> (raw)
In-Reply-To: <87ftrther0.fsf@nckx> (Tobias Geerinckx-Rice's message of "Mon, 11 Mar 2019 11:44:35 +0100")
Hello!
Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
skribis:
> I think they should.
>
> All of our package names are lower case, and it doesn't add value that
>
> $ guix package -A ExifTool
>
> matches zero, zip, zilch, nada, nothing, while
>
> $ guix package -A exiftool
> perl-image-exiftool 11.11 out gnu/packages/photo.scm:208:2
>
> does.
Indeed.
>>From 5876eb1fe6d412d7f2a556e0903cd2d87994ab9e Mon Sep 17 00:00:00 2001
> From: Tobias Geerinckx-Rice <me@tobias.gr>
> Date: Mon, 11 Mar 2019 11:37:11 +0100
> Subject: [PATCH] ui: Match package names case-insensitively.
>
> * guix/ui.scm (make-package-name-regexp): New variable.
> * guix/scripts/package.scm (options->upgrade-predicate, process-query):
> Use it.
[...]
> - (make-regexp* (or regexp "")))
> + (make-package-name-regexp (or regexp "")))
I don’t think the abstraction brings much here; I’d prefer
‘regexp/icase’ to be inlined. WDYT?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2019-03-15 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 10:44 [bug#34811] Make package name regexes case-insensitive Tobias Geerinckx-Rice
2019-03-15 22:11 ` Ludovic Courtès [this message]
2019-05-21 14:51 ` Ludovic Courtès
2020-11-30 22:10 ` bug#34811: " Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l833i0w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34811@debbugs.gnu.org \
--cc=somebody@not-sent-or-endorsed-by.tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).