From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUCc3-0002e7-2O for guix-patches@gnu.org; Fri, 24 May 2019 12:00:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUCc0-0000UT-RQ for guix-patches@gnu.org; Fri, 24 May 2019 12:00:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUCc0-0000Tv-A6 for guix-patches@gnu.org; Fri, 24 May 2019 12:00:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUCc0-0000Pw-7e for guix-patches@gnu.org; Fri, 24 May 2019 12:00:04 -0400 Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank) Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> Date: Fri, 24 May 2019 17:59:08 +0200 In-Reply-To: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> (Tk's message of "Mon, 20 May 2019 14:20:40 +0000") Message-ID: <874l5ju9mb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tk Cc: 35810@debbugs.gnu.org Hello Todor, Tk skribis: > Some of us at ECI (Environmental Cheminformatics), LCSB, University of Lu= xembourg > are in love with Scheme, GNU, Guile and Guix. Heh, cool. :-) > At ECI, there is a lot of mass spectrometry going on and there are plenty= of > R tools -- some written by us -- to analyse and annotate such spectra. An= yway, > this is our first contribution to Guix -- RMassBank (r-massbank package). > I have decided to create a separate package group for mass-spectrometry a= nd > include r-massbank in it. I could imagine packages defined here to end up= in > chemistry.scm, or under a new subpath, chemistry/mass-spectrometry.scm. O= nce > this first submission enters Guix, some more will follow. > > The packages themselves have been generated using > `guix import cran -r --archive=3Dbioconductor RMassBank` and minimally al= tered > to build successfully and not bother guix lint too much. Looks good to me. Ricardo, WDYT? > As this is my first contribution to guix, I am very much looking forward > to feedback. The file is OK as-is, but could you send directly the output of =E2=80=98git format-patch=E2=80=99? That makes it easier for us to apply the patch while preserving authorship information. Also, bonus points if you can come up with a commit log that follows our conventions. :-) https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.= html Anyway, glad to see more scientists join! You might be interested in too. Welcome! Thanks, Ludo=E2=80=99.