From: "Ludovic Courtès" <ludo@gnu.org>
To: Tk <tk.code@protonmail.com>
Cc: 35810@debbugs.gnu.org
Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank)
Date: Fri, 24 May 2019 17:59:08 +0200 [thread overview]
Message-ID: <874l5ju9mb.fsf@gnu.org> (raw)
In-Reply-To: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> (Tk's message of "Mon, 20 May 2019 14:20:40 +0000")
Hello Todor,
Tk <tk.code@protonmail.com> skribis:
> Some of us at ECI (Environmental Cheminformatics), LCSB, University of Luxembourg
> are in love with Scheme, GNU, Guile and Guix.
Heh, cool. :-)
> At ECI, there is a lot of mass spectrometry going on and there are plenty of
> R tools -- some written by us -- to analyse and annotate such spectra. Anyway,
> this is our first contribution to Guix -- RMassBank (r-massbank package).
> I have decided to create a separate package group for mass-spectrometry and
> include r-massbank in it. I could imagine packages defined here to end up in
> chemistry.scm, or under a new subpath, chemistry/mass-spectrometry.scm. Once
> this first submission enters Guix, some more will follow.
>
> The packages themselves have been generated using
> `guix import cran -r --archive=bioconductor RMassBank` and minimally altered
> to build successfully and not bother guix lint too much.
Looks good to me. Ricardo, WDYT?
> As this is my first contribution to guix, I am very much looking forward
> to feedback.
The file is OK as-is, but could you send directly the output of ‘git
format-patch’? That makes it easier for us to apply the patch while
preserving authorship information.
Also, bonus points if you can come up with a commit log that follows our
conventions. :-)
https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html
Anyway, glad to see more scientists join! You might be interested in
<https://guix-hpc.bordeaux.inria.fr/> too.
Welcome!
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-05-24 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:20 [bug#35810] [PATCH] Add RMassBank (r-massbank) Tk
2019-05-24 15:59 ` Ludovic Courtès [this message]
2019-05-25 14:00 ` Todor Kondić
2019-05-28 22:16 ` Ricardo Wurmus
2019-05-25 13:41 ` Todor Kondić
2019-07-07 7:06 ` [bug#35810] [PATCH] Add RMassBank (r-massbank) [CLOSING THIS ONE] Todor Kondić
2020-08-04 13:55 ` bug#35810: Closing [PATCH] Add RMassBank (r-massbank) Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l5ju9mb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35810@debbugs.gnu.org \
--cc=tk.code@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).