From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58534)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL7mt-0000Tp-Ar
 for guix-patches@gnu.org; Thu, 17 Oct 2019 11:34:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL7ms-00044o-Bw
 for guix-patches@gnu.org; Thu, 17 Oct 2019 11:34:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39915)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iL7ms-00044f-99
 for guix-patches@gnu.org; Thu, 17 Oct 2019 11:34:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iL7ms-0008AH-5A
 for guix-patches@gnu.org; Thu, 17 Oct 2019 11:34:02 -0400
Subject: [bug#37788] [PATCH] gnu: Add minisign.
Resent-Message-ID: <handler.37788.B37788.157132639031311@debbugs.gnu.org>
References: <20191017080233.dcsjsyh5ui6x67kj@rafflesia>
 <20191017080954.rxj4m7dmelakx7zv@rafflesia>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20191017080954.rxj4m7dmelakx7zv@rafflesia>
Date: Thu, 17 Oct 2019 17:32:58 +0200
Message-ID: <874l07gzf9.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 37788@debbugs.gnu.org


Hello Tanguy,

> Remove new blank line at EOF.

Please pass --subject-prefix="PATCH v2" to git format-patch so that it
is easier to identify patch revisions.

> +     ; No test suite

You can put it on the same line as the one below.

> +     `(#:tests? #f))

You also did forget to add the Copyright on top.

Otherwise seems fine :). I fixed the points above and pushed it.

Mathieu