[bug#38124] [PATCH] gnu: Add zam-plugins.

[bug#38124] [PATCH] gnu: Add zam-plugins.

[Alexandros Theodotou]

NOTE: This patch depends on 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38121

 From 03620d73893a4eb53cc294f653c72df0e945f9d5 Mon Sep 17 00:00:00 2001
 From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 10:35:27 +0000
Subject: [PATCH] gnu: Add zam-plugins.

* gnu/packages/music.scm: (zam-plugins): New variable.
---
  gnu/packages/music.scm | 48 ++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 48 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..616b4dc370 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
  ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
  ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
  ;;; Copyright © 2019 David Wilson <david@daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
  ;;;
  ;;; This file is part of GNU Guix.
  ;;;
@@ -4699,3 +4700,50 @@ You can also get metadata about the playing track 
such as the artist and title
  for integration into status line generators or other command-line 
tools.")
      (home-page "https://github.com/altdesktop/playerctl")
      (license license:lgpl3+)))
+
+(define-public zam-plugins
+  (package
+    (name "zam-plugins")
+    (version "3.11")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/zamaudio/zam-plugins.git")
+               (commit version)
+               (recursive? #t))) ; for DPF
+        (file-name (string-append name "-" version))
+        (sha256
+          (base32
+            "0jlbxm0g93plgd3g4r9rsr0c7868ms49bs0ljpqb6kw6132hsapp"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             "HAVE_ZITA_CONVOLVER=true")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _ (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("fftwf" ,fftwf)
+       ("jack" ,jack-1)
+       ("liblo" ,liblo)
+       ("libsamplerate" ,libsamplerate)
+       ("mesa" ,mesa)
+       ("zita-convolver" ,zita-convolver)))
+    (native-inputs
+     `(("ladspa" ,ladspa)
+       ("lv2" ,lv2)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "Collection of LADSPA/LV2/VST2/JACK audio processing 
plugins")
+    (description
+     "Zam plugins is a collection of audio processing plugins in the 
LADSPA,
+LV2 and VST2 formats, as well as standalone JACK versions. The 
collection
+includes ZaMaximX2, ZamAutoSat, ZamComp, ZamCompX2, ZamEQ2, ZamGEQ31,
+ZamHeadX2, ZamPhono, ZamGate, ZamGateX2, ZamTube, ZamDelay, 
ZamDynamicEQ,
+ZaMultiComp, ZaMultiCompX2 and ZamSynth.")
+    (home-page "http://www.zamaudio.com/?p=976")
+    (license license:gpl2+)))
-- 
2.24.0

[bug#38124] [PATCH] gnu: Add zam-plugins.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2096 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> NOTE: This patch depends on 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38121
>
>  From 03620d73893a4eb53cc294f653c72df0e945f9d5 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 10:35:27 +0000
> Subject: [PATCH] gnu: Add zam-plugins.
>
> * gnu/packages/music.scm: (zam-plugins): New variable.

Like the other patches, please resend it (preferably through 'git
send-email') after adjusting the indentation.

[...]

> +(define-public zam-plugins
> +  (package
> +    (name "zam-plugins")
> +    (version "3.11")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/zamaudio/zam-plugins.git")
> +               (commit version)
> +               (recursive? #t))) ; for DPF

Can you describe what DPF is?  Is it possible to package it separately?

> +        (file-name (string-append name "-" version))
> +        (sha256
> +          (base32
> +            "0jlbxm0g93plgd3g4r9rsr0c7868ms49bs0ljpqb6kw6132hsapp"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f  ; no "check" target
> +       #:make-flags
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +             "HAVE_ZITA_CONVOLVER=true")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'set-CC-variable
> +           (lambda _ (setenv "CC" "gcc") #t))
> +         (delete 'configure))))
> +    (inputs
> +     `(("fftwf" ,fftwf)
> +       ("jack" ,jack-1)
> +       ("liblo" ,liblo)
> +       ("libsamplerate" ,libsamplerate)
> +       ("mesa" ,mesa)
> +       ("zita-convolver" ,zita-convolver)))
> +    (native-inputs
> +     `(("ladspa" ,ladspa)
> +       ("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "Collection of LADSPA/LV2/VST2/JACK audio processing 
> plugins")

Maybe just "Audio processing plugins"?  I suppose even more will be
supported in the future :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38124] [PATCH] gnu: Add zam-plugins.

[Alexandros Theodotou]

[-- Attachment #1.1: Type: text/plain, Size: 30 bytes --]

Updated and clarified on DPF

[-- Attachment #1.2: 0001-gnu-Add-zam-plugins.patch --]
[-- Type: text/x-patch, Size: 2669 bytes --]

From 10b8905b8e117d68e6b8b8f86087111a1fb5dae8 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 10:35:27 +0000
Subject: [PATCH] gnu: Add zam-plugins.

* gnu/packages/music.scm: (zam-plugins): New variable.
---
 gnu/packages/music.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f023685df..17288f845f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4737,3 +4737,55 @@ for integration into status line generators or other command-line tools.")
 effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
 and reverb.")
     (license license:gpl2+)))
+
+(define-public zam-plugins
+  (package
+    (name "zam-plugins")
+    (version "3.11")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+          (git-reference
+            (url "https://github.com/zamaudio/zam-plugins.git")
+            (commit version)
+            ;; Recursive to fetch the DISTRHO plugin framework. This
+            ;; framework is intended to be included in the sources
+            ;; and not to be used as a library
+            (recursive? #t)))
+        (file-name (string-append name "-" version))
+        (sha256
+          (base32
+            "0jlbxm0g93plgd3g4r9rsr0c7868ms49bs0ljpqb6kw6132hsapp"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f  ; no "check" target
+       #:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+             "HAVE_ZITA_CONVOLVER=true")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-CC-variable
+           (lambda _
+             (setenv "CC" "gcc") #t))
+         (delete 'configure))))
+    (inputs
+     `(("fftwf" ,fftwf)
+       ("jack" ,jack-1) ; for the standalone JACK application
+       ("liblo" ,liblo)
+       ("libsamplerate" ,libsamplerate)
+       ("mesa" ,mesa)
+       ("zita-convolver" ,zita-convolver)))
+    (native-inputs
+     `(("ladspa" ,ladspa)
+       ("lv2" ,lv2)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "Collection of audio processing plugins")
+    (description
+     "Zam plugins is a collection of audio processing plugins in the LADSPA,
+LV2 and VST2 formats, as well as standalone JACK versions. The collection
+includes ZaMaximX2, ZamAutoSat, ZamComp, ZamCompX2, ZamEQ2, ZamGEQ31,
+ZamHeadX2, ZamPhono, ZamGate, ZamGateX2, ZamTube, ZamDelay, ZamDynamicEQ,
+ZaMultiComp, ZaMultiCompX2 and ZamSynth.")
+    (home-page "http://www.zamaudio.com/?p=976")
+    (license license:gpl2+)))
-- 
2.24.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#38124: [PATCH] gnu: Add zam-plugins.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> From 10b8905b8e117d68e6b8b8f86087111a1fb5dae8 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 10:35:27 +0000
> Subject: [PATCH] gnu: Add zam-plugins.
>
> * gnu/packages/music.scm: (zam-plugins): New variable.

Applied after changing indentation and adjusting description to appease
`guix lint`.

[...]

> +        (file-name (string-append name "-" version))

I also changed this to use 'git-file-name'.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]