From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45472)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igcS3-0007i6-Sc
 for guix-patches@gnu.org; Sun, 15 Dec 2019 17:33:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igcRj-0007Yk-3Y
 for guix-patches@gnu.org; Sun, 15 Dec 2019 17:33:23 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:59643)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1igcRi-0007Xm-Rn
 for guix-patches@gnu.org; Sun, 15 Dec 2019 17:33:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igcRi-0002nm-Q5
 for guix-patches@gnu.org; Sun, 15 Dec 2019 17:33:02 -0500
Subject: [bug#38625] [PATCH] music.scm: Add glyr
Resent-Message-ID: <handler.38625.B38625.157644912510667@debbugs.gnu.org>
References: <CA+2hkpVVJHMgWNiWWF7Ydvr0W+DzUqq7NQ6fLfFWuJAx2JSwCw@mail.gmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <CA+2hkpVVJHMgWNiWWF7Ydvr0W+DzUqq7NQ6fLfFWuJAx2JSwCw@mail.gmail.com>
Date: Sun, 15 Dec 2019 23:31:55 +0100
Message-ID: <874ky1cjac.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Riku Viitanen <riku.viitanen0@gmail.com>
Cc: 38625@debbugs.gnu.org


Hi Riku,

thank you for your contribution.
Could you please resend this as a git formatted patch?  See the
Contributing section in the manual for more information on the workflow.

>>     (source
>>      (origin
>>        (method url-fetch)
>>        (uri (string-append "https://github.com/sahib/glyr/archive/"
>>                            version ".tar.gz"))

These /archive tarballs are automatically generated, so they can change
in place without prior notice.  Please use git-fetch instead.

>>     (arguments
>>      '(#:tests? #f)) ; no check target))

Please remove the trailing =E2=80=9C))=E2=80=9D.

>>     (inputs
>>      `(("glib" ,glib)
>>        ("curl" ,curl)
>>        ("sqlite" ,sqlite)
>>        ("pkg-config" ,pkg-config)))

pkg-config should be a native-input.

>>     (home-page "https://github.com/sahib/glyr")
>>     (synopsis "Search engine for music related metadata")
>>     (description
>>      "It comes both in a command-line interface tool (@command{glyrc})
> and as a C library (libglyr), both [=E2=80=A6]

Please =E2=80=9Creflow=E2=80=9D the description to fit 80 columns and perha=
ps shorten it
a little.

>>     (license license:lgpl3)))

Only version 3 or also any other version?

--=20
Ricardo