unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Riku Viitanen <riku.viitanen0@gmail.com>
Cc: 38625@debbugs.gnu.org
Subject: [bug#38625] [PATCH] music.scm: Add glyr
Date: Sun, 15 Dec 2019 23:31:55 +0100	[thread overview]
Message-ID: <874ky1cjac.fsf@elephly.net> (raw)
In-Reply-To: <CA+2hkpVVJHMgWNiWWF7Ydvr0W+DzUqq7NQ6fLfFWuJAx2JSwCw@mail.gmail.com>


Hi Riku,

thank you for your contribution.
Could you please resend this as a git formatted patch?  See the
Contributing section in the manual for more information on the workflow.

>>     (source
>>      (origin
>>        (method url-fetch)
>>        (uri (string-append "https://github.com/sahib/glyr/archive/"
>>                            version ".tar.gz"))

These /archive tarballs are automatically generated, so they can change
in place without prior notice.  Please use git-fetch instead.

>>     (arguments
>>      '(#:tests? #f)) ; no check target))

Please remove the trailing “))”.

>>     (inputs
>>      `(("glib" ,glib)
>>        ("curl" ,curl)
>>        ("sqlite" ,sqlite)
>>        ("pkg-config" ,pkg-config)))

pkg-config should be a native-input.

>>     (home-page "https://github.com/sahib/glyr")
>>     (synopsis "Search engine for music related metadata")
>>     (description
>>      "It comes both in a command-line interface tool (@command{glyrc})
> and as a C library (libglyr), both […]

Please “reflow” the description to fit 80 columns and perhaps shorten it
a little.

>>     (license license:lgpl3)))

Only version 3 or also any other version?

-- 
Ricardo

  reply	other threads:[~2019-12-15 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 16:10 [bug#38625] [PATCH] music.scm: Add glyr Riku Viitanen
2019-12-15 22:31 ` Ricardo Wurmus [this message]
     [not found]   ` <CA+2hkpV44p4Lw2dh46j2_yYMAn0tv0Y5Q4hzQ_mrZWhD1H3ODQ@mail.gmail.com>
2019-12-18 16:57     ` [bug#38625] Fwd: " Riku Viitanen
2020-11-19  9:27       ` bug#38625: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ky1cjac.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=38625@debbugs.gnu.org \
    --cc=riku.viitanen0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).