From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42583) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii5l1-0007yF-Pd for guix-patches@gnu.org; Thu, 19 Dec 2019 19:03:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ii5l0-000239-HF for guix-patches@gnu.org; Thu, 19 Dec 2019 19:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ii5l0-00021I-8M for guix-patches@gnu.org; Thu, 19 Dec 2019 19:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ii5l0-0008Eb-3D for guix-patches@gnu.org; Thu, 19 Dec 2019 19:03:02 -0500 Subject: [bug#35866] [PATCH] gnu: Add qtwebengine. Resent-Message-ID: From: mike.rosset@gmail.com References: <20190523062344.20601-1-mrosset@bufio.org> <20191218203223.22861-1-mike.rosset@gmail.com> <87d0ckqd96.fsf@elephly.net> Date: Thu, 19 Dec 2019 16:02:46 -0800 In-Reply-To: <87d0ckqd96.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 19 Dec 2019 21:19:49 +0100") Message-ID: <874kxv7tjt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: Marius Bakke , GNU Guix maintainers , 35866@debbugs.gnu.org Ricardo Wurmus writes: >> + (description "Qt5WebEngine provides support for web >> +applications using the Chromium browser project.") > > Does this include the unmodified Chromium source code? We need to > ensure that the variant we are distributing here does not contain any > misfeatures that Chromium is known for (e.g. DRM support) and that only > free software is included. The chromium source is modified to remove google services etc. quoting from https://wiki.qt.io/QtWebEngine. - Binary files are stripped out - Auxiliary services that talk to Google platforms are stripped out - The codebase is modularized to allow use of system libraries like OpenSSL There is also a rebase patch process to allow upgrading to the current chromium. > Marius and others previously worked very hard on making sure that the > ungoogled-chromium package complied with our expectations for Chromium. > I wonder what work needs to be done on the sources included in this > package to accomplish the same goal. > > Did you happen to investigate this? It was proposed that maybe the ungoogled-chrome sources/changes could be used. But to me it seems to Qt is already doing the right thing here. I'm just not confident with the size of this code base, and with the QT specific front end. the ungoogled sources could be dropped in and expected to work.