[bug#39152] [PATCH] Allow extra config content in mysql-configuration

[bug#39152] [PATCH] Allow extra config content in mysql-configuration

[Alex Sassmannshausen]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

Hello,

Attached is a patch that proposes changing the mysql-service so that the
user can inject additional mysql configuration into the default
configuration file.

I currently use the patch in a private channel and it seems to work
great.

Best wishes,

Alex


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-services-Allow-extra-content-in-mysql-configurat.patch --]
[-- Type: text/x-diff, Size: 1362 bytes --]

From 3e2139c6e6cecfd34f7e9423c23e57b3d9dbf197 Mon Sep 17 00:00:00 2001
From: Alex Sassmannshausen <alex@komputilo.eu>
Date: Thu, 16 Jan 2020 17:17:48 +0100
Subject: [PATCH] gnu: services: Allow extra content in mysql configuration.

* gnu/services/databases.scm (<mysql-configuration>): New field.
  (mysql-configuration-file): Use it.
---
 gnu/services/databases.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
index a26eeb20cc..473ece4e97 100644
--- a/gnu/services/databases.scm
+++ b/gnu/services/databases.scm
@@ -463,7 +463,8 @@ storage:
   mysql-configuration make-mysql-configuration
   mysql-configuration?
   (mysql mysql-configuration-mysql (default mariadb))
-  (port mysql-configuration-port (default 3306)))
+  (port mysql-configuration-port (default 3306))
+  (extra-content mysql-configuration-extra-content (default "")))
 
 (define %mysql-accounts
   (list (user-group
@@ -478,11 +479,12 @@ storage:
 
 (define mysql-configuration-file
   (match-lambda
-    (($ <mysql-configuration> mysql port)
+    (($ <mysql-configuration> mysql port extra-content)
      (mixed-text-file "my.cnf" "[mysqld]
 datadir=/var/lib/mysql
 socket=/run/mysqld/mysqld.sock
 port=" (number->string port) "
+" extra-content "
 "))))
 
 (define (%mysql-activation config)
-- 
2.23.0

[bug#39152] [PATCH] Allow extra config content in mysql-configuration

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]


Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> Hello,
>
> Attached is a patch that proposes changing the mysql-service so that the
> user can inject additional mysql configuration into the default
> configuration file.
>
> I currently use the patch in a private channel and it seems to work
> great.

Looks good to me :)

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

[bug#39152] [PATCH] Allow extra config content in mysql-configuration

[Alex Sassmannshausen]

Cheers for the review, I've pushed and will close the issue now.

Alex

Christopher Baines <mail@cbaines.net> writes:

> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:
>
>> Hello,
>>
>> Attached is a patch that proposes changing the mysql-service so that the
>> user can inject additional mysql configuration into the default
>> configuration file.
>>
>> I currently use the patch in a private channel and it seems to work
>> great.
>
> Looks good to me :)
>
> Thanks,
>
> Chris

bug#39152: Pushed, Done.

[Alex Sassmannshausen]