From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45204) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCfVA-00027y-Vv for guix-patches@gnu.org; Fri, 13 Mar 2020 04:17:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCfV9-0002p0-SJ for guix-patches@gnu.org; Fri, 13 Mar 2020 04:17:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52122) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCfV8-0002oB-Au for guix-patches@gnu.org; Fri, 13 Mar 2020 04:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jCfV8-00015Z-7A for guix-patches@gnu.org; Fri, 13 Mar 2020 04:17:02 -0400 Subject: [bug#40035] Add widelands game Resent-Message-ID: From: Nicolas Goaziou References: <87o8t2gpqx.fsf@posteo.mx> <87imj9skzr.fsf@nicolasgoaziou.fr> <87k13pkku4.fsf@posteo.mx> Date: Fri, 13 Mar 2020 09:16:37 +0100 In-Reply-To: <87k13pkku4.fsf@posteo.mx> (Alberto EFG's message of "Thu, 12 Mar 2020 21:14:11 -0600") Message-ID: <874kussm8q.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alberto EFG Cc: 40035@debbugs.gnu.org Hello, Alberto EFG writes: > I added all the changes. The synopsis is slightly different than > requested, because of character length. Thanks! > +(define-public widelands > + (package > + (name "widelands") > + (version "20") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://launchpad.net/widelands/build20/build20/+download/" > + name "-build" version ".tar.bz2")) I suggest to use version everywhere in the `uri' string: (string-append "https://launchpad.net/widelands/build" version "/build" version "/" ...) > + (description > + "Widelands is a strategy game aiming for gameplay similar to Settlers II by > + BlueByte. > + > + In this game, you start out on a small piece of land with nothing more than > + a few of useful resources. Using those, you can build yourself an empire > + with many thousands of inhabitants. On your way towards this goal, you will > + have to build up an economic infrastructure, explore the lands around you > + and face enemies who are trying to rule the world just like you do.") The description should not be indented. > + (license (list > + license:gpl2+ > + license:gpl3+ > + license:expat > + license:zlib > + license:silofl1.1 > + license:asl2.0 > + license:cc-by-sa3.0)))) I suggest to add a comment explaining that the software, as a whole, is gpl2+, but assets are released under various licenses. BTW, the source ships with "minizip" and "gettext" in "src/third_party". Could you try unbundling them and use the ones provided by Guix? Otherwise, LGTM! Regards, -- Nicolas Goaziou