unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alberto EFG <albertoefg@posteo.mx>
Cc: 40035@debbugs.gnu.org
Subject: [bug#40035] Add widelands game
Date: Fri, 13 Mar 2020 09:16:37 +0100	[thread overview]
Message-ID: <874kussm8q.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k13pkku4.fsf@posteo.mx> (Alberto EFG's message of "Thu, 12 Mar 2020 21:14:11 -0600")

Hello,

Alberto EFG <albertoefg@posteo.mx> writes:

> I added all the changes. The synopsis is slightly different than
> requested, because of character length.

Thanks!

> +(define-public widelands
> +  (package
> +    (name "widelands")
> +    (version "20")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://launchpad.net/widelands/build20/build20/+download/"
> +                           name "-build" version ".tar.bz2"))

I suggest to use version everywhere in the `uri' string:

  (string-append "https://launchpad.net/widelands/build" version "/build" version "/" ...)

> +    (description
> +     "Widelands is a strategy game aiming for gameplay similar to Settlers II by
> +    BlueByte.
> +
> +    In this game, you start out on a small piece of land with nothing more than
> +    a few of useful resources.  Using those, you can build yourself an empire
> +    with many thousands of inhabitants.  On your way towards this goal, you will
> +    have to build up an economic infrastructure, explore the lands around you
> +    and face enemies who are trying to rule the world just like you do.")

The description should not be indented.

> +    (license (list
> +              license:gpl2+
> +              license:gpl3+
> +              license:expat
> +              license:zlib
> +              license:silofl1.1
> +              license:asl2.0
> +              license:cc-by-sa3.0))))

I suggest to add a comment explaining that the software, as a whole, is
gpl2+, but assets are released under various licenses.

BTW, the source ships with "minizip" and "gettext" in "src/third_party".
Could you try unbundling them and use the ones provided by Guix?

Otherwise, LGTM!

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2020-03-13  8:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  4:29 [bug#40035] Add widelands game Alberto EFG
2020-03-12 14:31 ` Nicolas Goaziou
2020-03-13  3:14   ` Alberto EFG
2020-03-13  8:16     ` Nicolas Goaziou [this message]
2020-06-18 21:22       ` Nicolas Goaziou
2020-06-18 22:58         ` Jonathan Brielmaier
2020-06-19  7:01           ` Nicolas Goaziou
2020-06-21  6:33           ` Efraim Flashner
2020-06-19 12:09         ` Tobias Geerinckx-Rice via Guix-patches via
2020-06-19 18:59           ` Nicolas Goaziou
2020-06-19 20:46             ` Nicolas Goaziou
2020-06-19 21:14             ` Tobias Geerinckx-Rice via Guix-patches via
2020-06-19 21:55               ` Nicolas Goaziou
2020-06-30 15:50                 ` bug#40035: " Nicolas Goaziou
2020-06-19 12:30 ` [bug#40035] " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kussm8q.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=40035@debbugs.gnu.org \
    --cc=albertoefg@posteo.mx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).