From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Josh Marshall <joshua.r.marshall.1991@gmail.com>
Cc: 41556-done@debbugs.gnu.org
Subject: bug#41556: [PATCH] gnu: aegis: Update homepage link and fix build failure
Date: Wed, 27 May 2020 13:34:28 +0200 [thread overview]
Message-ID: <874ks1627v.fsf@nckx> (raw)
In-Reply-To: <20200527031226.64428-1-joshua.r.marshall.1991@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
Josh,
Josh Marshall 写道:
> * gnu/packages/version-control.scm (aegis):
^^^^
‘git log’ adds 4 leading spaces to commit message bodies but you
don't need to add (or, I presume, copy/paste :-) them yourself.
> Update homepage link and fix build failure
Thanks! I've split these two unrelated changes into two commits.
SF project pages aren't goot home pages but this project looks
very dead indeed. Are you fixing this because you use it?
> @@ -1885,7 +1885,10 @@ accessed and migrated on modern
> systems.")
> ("ed" ,ed)))
> (arguments
> `(#:configure-flags (list "--with-no-aegis-configured"
> -
> "--sharedstatedir=/var/com/aegis")
> +
> "--sharedstatedir=/var/com/aegis"
> + ;; Uses the old 'throw()' specifier
> with 'new'
> + ;; which changed in C++11.
> + "CXXFLAGS=-std=c++03")
^^^^…
It's worth running ‘guix lint’ even after trivial changes: these
are tabs & we're a spaces family. Changed and pushed as
812dad08764af5ae4d80394732dcc1481742db3a et al.
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2020-05-27 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 3:12 [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix build failure Josh Marshall
2020-05-27 11:34 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-05-27 12:32 ` Josh Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ks1627v.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=41556-done@debbugs.gnu.org \
--cc=joshua.r.marshall.1991@gmail.com \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).