From: Marius Bakke <marius@gnu.org>
To: Tom Zander <tomz@freedommail.ch>, 41562@debbugs.gnu.org
Subject: [bug#41562] use consistent arguments.
Date: Fri, 29 May 2020 22:56:18 +0200 [thread overview]
Message-ID: <874kry4g0d.fsf@gnu.org> (raw)
In-Reply-To: <3098426.mvXUDI8C0e@cherry>
[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]
Tom Zander via Guix-patches via <guix-patches@gnu.org> writes:
> As suggested on IRC
> --
> Tom Zander
>>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001
> From: TomZ <tomz@freedommail.ch>
> Date: Wed, 27 May 2020 13:21:58 +0200
> Subject: [PATCH] gnu: flowee: Disable unpredictable test.
>
> * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts
> which fail half the time in a build, so disable the test.
Can you move this piece of information to a comment in the code?
Also, this should say (flowee)[arguments]: ...
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index f182057bb4..d176ac0660 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over RPC.")
> (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc"))))
> (build-system cmake-build-system)
> (arguments
> - `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF")
> + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" "-Denable_gui=OFF")
This should probably not be here?
> #:phases
> (modify-phases %standard-phases
> (add-before 'configure 'make-qt-deterministic
> @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over RPC.")
> (lambda _
> (substitute* "testing/CMakeLists.txt"
> (("test_api") ""))
Can this be removed? It looks like it tries to do the same as your new
substitution below.
> + (substitute* "testing/CMakeLists.txt"
> + (("add_subdirectory\\(api\\)") ""))
> #t))
> (add-after 'configure 'set-build-info
> ;; Their genbuild.sh to generate a build.h fails in guix (no .git dir) .
> --
> 2.25.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-29 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 11:25 [bug#41562] fix tests failing on flowee package Tom Zander via Guix-patches via
2020-05-29 13:27 ` [bug#41562] use consistent arguments Tom Zander via Guix-patches via
2020-05-29 20:56 ` Marius Bakke [this message]
2020-05-30 7:40 ` Tom Zander via Guix-patches via
2020-05-30 8:07 ` Marius Bakke
2020-05-30 12:21 ` Tom Zander via Guix-patches via
2020-05-30 12:34 ` bug#41562: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kry4g0d.fsf@gnu.org \
--to=marius@gnu.org \
--cc=41562@debbugs.gnu.org \
--cc=tomz@freedommail.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).