From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id G5CzFSbkVF/beQAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 13:29:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2MfbECbkVF+IAgAAB5/wlQ (envelope-from ) for ; Sun, 06 Sep 2020 13:29:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B514794021E for ; Sun, 6 Sep 2020 13:29:09 +0000 (UTC) Received: from localhost ([::1]:51298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEujC-0004YP-Sq for larch@yhetil.org; Sun, 06 Sep 2020 09:29:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEuj8-0004YJ-Tu for guix-patches@gnu.org; Sun, 06 Sep 2020 09:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEuj8-00037c-KW for guix-patches@gnu.org; Sun, 06 Sep 2020 09:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEuj8-0003PC-GW for guix-patches@gnu.org; Sun, 06 Sep 2020 09:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43239] [PATCH] gnu: Add guile-prometheus. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Sep 2020 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43239@debbugs.gnu.org Received: via spool by 43239-submit@debbugs.gnu.org id=B43239.159939890313045 (code B ref 43239); Sun, 06 Sep 2020 13:29:02 +0000 Received: (at 43239) by debbugs.gnu.org; 6 Sep 2020 13:28:23 +0000 Received: from localhost ([127.0.0.1]:45046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEuiV-0003OL-40 for submit@debbugs.gnu.org; Sun, 06 Sep 2020 09:28:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEuiT-0003O9-Dg for 43239@debbugs.gnu.org; Sun, 06 Sep 2020 09:28:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEuiO-000358-0r; Sun, 06 Sep 2020 09:28:16 -0400 Received: from [2a01:e0a:19b:d9a0:9d9d:97cc:d92a:8ac0] (port=41314 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEuiN-0001YY-0V; Sun, 06 Sep 2020 09:28:15 -0400 From: Mathieu Othacehe References: <20200906120744.20651-1-mail@cbaines.net> Date: Sun, 06 Sep 2020 15:28:13 +0200 In-Reply-To: <20200906120744.20651-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 6 Sep 2020 13:07:44 +0100") Message-ID: <874kobxceq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: skbW5ctrMIhU Hello Christopher, > + (name "guile-prometheus") > + (version (string-append "0-" revision "." (string-take commit 7))) I think that the usual pattern is something like: --8<---------------cut here---------------start------------->8--- (version (git-version "0.0.1" revision commit)) --8<---------------cut here---------------end--------------->8--- > + (inputs > + `(("guile" ,guile-3.0))) > + (home-page "https://git.cbaines.net/guile/prometheus") The linter reports that this URL is not reachable. > + (synopsis "Prometheus client library for Guile") > + (description > + "This Guile library provides instrumentation code intended to be used > +with the Prometheus time series service. Counter, gauge and histogram metric > +types are supported.") > + (license license:gpl3+)))) Otherwise, looks fine! Turns out I'm currently working on adding some metrics to Cuirass[1]. With commit 154232b, we should be able to add the two metrics proposed in the bug report. The next step is to actually compute, save and display those metrics. I'm just discovering this prometheus but may it could be a good candidate? Do you happen to have a server running prometheus? Thanks, Mathieu [1]: https://issues.guix.gnu.org/32548.