From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4BusEYm6Vl9qVgAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 22:56:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EDSVDYm6Vl9lSwAAB5/wlQ (envelope-from ) for ; Mon, 07 Sep 2020 22:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B81DA940142 for ; Mon, 7 Sep 2020 22:56:08 +0000 (UTC) Received: from localhost ([::1]:50998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFQ3T-0007c4-8Z for larch@yhetil.org; Mon, 07 Sep 2020 18:56:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFQ3O-0007aZ-33 for guix-patches@gnu.org; Mon, 07 Sep 2020 18:56:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFQ3N-0004Dz-Qg for guix-patches@gnu.org; Mon, 07 Sep 2020 18:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFQ3N-0004iq-Pl for guix-patches@gnu.org; Mon, 07 Sep 2020 18:56:01 -0400 Subject: bug#43204: [PATCH] gnu: taglib: Propagate zlib. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 22:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 43204-done@debbugs.gnu.org, mike@rohleder.de Mail-Followup-To: 43204@debbugs.gnu.org, ludo@gnu.org, mike@rohleder.de Received: via spool by 43204-done@debbugs.gnu.org id=D43204.159951935018131 (code D ref 43204); Mon, 07 Sep 2020 22:56:01 +0000 Received: (at 43204-done) by debbugs.gnu.org; 7 Sep 2020 22:55:50 +0000 Received: from localhost ([127.0.0.1]:51341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFQ3C-0004iN-H5 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 18:55:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFQ3A-0004i8-0y for 43204-done@debbugs.gnu.org; Mon, 07 Sep 2020 18:55:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53312) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFQ33-000481-HT; Mon, 07 Sep 2020 18:55:41 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52684 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFQ2t-0003Tt-LM; Mon, 07 Sep 2020 18:55:40 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> <875z8pkck2.fsf@gnu.org> <87eendpuvl.fsf@gmx.com> Date: Tue, 08 Sep 2020 00:55:25 +0200 In-Reply-To: <87eendpuvl.fsf@gmx.com> (Pierre Langlois's message of "Mon, 07 Sep 2020 14:41:02 +0100") Message-ID: <874ko9fb8i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: X3pCF1+1+srR Pierre Langlois skribis: > Ludovic Court=C3=A8s writes: [...] >> commit d8124a707602980556fd33c7dbf9f7483fe1d0df >> Author: Ludovic Court=C3=A8s >> Date: Mon Sep 7 09:56:08 2020 +0200 >> >> gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. >>=20=20=20=20=20 >> Fixes compilation of emacs-emms-print-metadata. >>=20=20=20=20=20 >> * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. > > LGTM! > > I was originally thinking we could just drop the `-lz`, since it > /should/ only be needed for people who statically link with taglib, and > we only ship shared libs. But actually, it's probably safer to follow > what upstream is doing. Yeah. Pushed as d2a7114e0b46fccad1e02e301c58a5124f361c5c, thanks! Ludo=E2=80=99.