From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uaj/N4GOXl8ldAAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 21:26:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cBK6MYGOXl9MRwAAbx9fmQ (envelope-from ) for ; Sun, 13 Sep 2020 21:26:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 610659404C8 for ; Sun, 13 Sep 2020 21:26:25 +0000 (UTC) Received: from localhost ([::1]:42058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHZVw-0001Eu-03 for larch@yhetil.org; Sun, 13 Sep 2020 17:26:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHZVb-000108-GF for guix-patches@gnu.org; Sun, 13 Sep 2020 17:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHZVb-0004HF-7D for guix-patches@gnu.org; Sun, 13 Sep 2020 17:26:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHZVb-00068D-4Y for guix-patches@gnu.org; Sun, 13 Sep 2020 17:26:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43332] [PATCH] build-system: linux-module: Delete some huge items that we probably don't need. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 21:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43332 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 43332@debbugs.gnu.org Received: via spool by 43332-submit@debbugs.gnu.org id=B43332.160003235423541 (code B ref 43332); Sun, 13 Sep 2020 21:26:03 +0000 Received: (at 43332) by debbugs.gnu.org; 13 Sep 2020 21:25:54 +0000 Received: from localhost ([127.0.0.1]:51945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZVR-00067d-VX for submit@debbugs.gnu.org; Sun, 13 Sep 2020 17:25:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZVP-00067N-Ls for 43332@debbugs.gnu.org; Sun, 13 Sep 2020 17:25:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38708) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHZVJ-0004CT-V0; Sun, 13 Sep 2020 17:25:45 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48038 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHZVJ-0004l3-5t; Sun, 13 Sep 2020 17:25:45 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200911110735.8208-1-dannym@scratchpost.org> Date: Sun, 13 Sep 2020 23:25:35 +0200 In-Reply-To: <20200911110735.8208-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 11 Sep 2020 13:07:35 +0200") Message-ID: <874ko19xo0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: u2wgHDm5+CeR Hi Danny, Danny Milosavljevic skribis: > * guix/build-system/linux-module.scm (make-linux-module-builder): Delete > some huge items that we probably don't need. Yay! I=E2=80=99m fine with either v1 or v2, with one nit: > + (for-each > + (lambda (name) > + (if (file-exists? name) > + (delete-file-recursively name))) > + (map > + (lambda (name) > + (string-append out-lib-build "/" name)) > + '(;"arch" ; 137 MB ; Note: "scripts/dtc" depends on "a= rch". > + ;"tools" ; 44 MB ; Note: is built by our 'build phas= e. > + "tools/testing" ; 14 MB > + "tools/perf" ; 17 MB > + "drivers" ; 600 MB > + "Documentation" ; 52 MB > + "fs" ; 43 MB > + "net" ; 33 MB > + "samples" ; 2 MB > + "sound"))) ; 40 MB Usually the first argument to =E2=80=98map=E2=80=99 and =E2=80=98for-each= =E2=80=99 is on the same line: (for-each (lambda =E2=80=A6) If you=E2=80=99re afraid of hitting the 80 char limit or something, then I suggest defining a local procedure. Also, use =E2=80=98when=E2=80=99 instead of a one-arm =E2=80=98if=E2=80=99,= for clarity. Thanks! Ludo=E2=80=99.