From: Christopher Baines <mail@cbaines.net>
To: Alexandru-Sergiu Marton <brown121407@posteo.ro>
Cc: 44620@debbugs.gnu.org
Subject: [bug#44620] [PATCH v2] gnu: Add gmni.
Date: Sun, 15 Nov 2020 19:23:49 +0000 [thread overview]
Message-ID: <874klqctkq.fsf@cbaines.net> (raw)
In-Reply-To: <20201113170201.5680-1-brown121407@posteo.ro>
[-- Attachment #1: Type: text/plain, Size: 3543 bytes --]
Alexandru-Sergiu Marton <brown121407@posteo.ro> writes:
> * gnu/packages/web-browsers.scm (gmni): New variable.
Hi,
Thanks for the patch :) I've made some comments below.
> ---
> This second version simplifies the arguments section by using #:make-flags to
> set CC, rather than using an environment variable.
>
> gnu/packages/web-browsers.scm | 39 +++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 5cb5185a31..b652e8d472 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -13,6 +13,7 @@
> ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan@disroot.org>
> ;;; Copyright © 2020 B. Wilson <elaexuotee@wilsonb.com>
> ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
> +;;; Copyright © 2020 Alexandru-Sergiu Marton <brown121407@posteo.ro>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -60,6 +61,7 @@
> #:use-module (gnu packages lisp)
> #:use-module (gnu packages lisp-xyz)
> #:use-module (gnu packages lua)
> + #:use-module (gnu packages man)
> #:use-module (gnu packages ncurses)
> #:use-module (gnu packages perl)
> #:use-module (gnu packages pkg-config)
> @@ -584,6 +586,43 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
> (define-public sbcl-next
> (deprecated-package "sbcl-next" nyxt))
>
> +(define-public gmni
> + (let ((commit "4a6172f1bf9cb41eb1ce3a5f720f9ebe4febc62b")
> + (revision "0"))
> + (package
> + (name "gmni")
> + (version (git-version "0" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~sircmpwn/gmni")
> + (commit commit)))
> + (sha256
> + (base32
> + "1nznkk1ccm5l09glalkv8bmhspqhvmh74ca18cfpdpbwkbzdzc7i"))
> + (file-name (git-file-name name version))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f
I'm guessing there are no tests to run, but a comment saying that would
be good.
> + #:make-flags (list "CC=gcc")))
I think it would be better to put something like:
(string-append "CC=" ,(cc-for-target))
As I believe that helps when compiling for other architectures. I copied
that from the f3 package if you want an example in context.
> + (inputs
> + `(("openssl" ,openssl)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("scdoc" ,scdoc)))
> + (home-page "https://sr.ht/~sircmpwn/gmni")
> + (synopsis "Gemini client")
Is there some way of making this more descriptive, like saying it's a
command line client?
> + (description "This is a Gemini client. Included are:
> +
> +@itemize
> +@item A CLI utility (like curl): gmni
> +@item A line-mode browser: gmnlm
> +@end itemize")
I'd probably change the start of this to "The gmni package includes:",
as that repeats the synopsis less.
> + (license (list license:gpl3+
> + (license:non-copyleft
> + "https://curl.se/docs/copyright.html"
> + "Used only for files taken from curl."))))))
> +
> (define-public bombadillo
> (package
> (name "bombadillo")
Would you be able to send an updated patch?
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2020-11-15 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 16:51 [bug#44620] [PATCH] gnu: Add gmni Alexandru-Sergiu Marton
2020-11-13 17:02 ` [bug#44620] [PATCH v2] " Alexandru-Sergiu Marton
2020-11-15 19:23 ` Christopher Baines [this message]
2020-11-16 21:55 ` Alexandru-Sergiu Marton
2020-11-29 22:30 ` Ludovic Courtès
2020-11-30 9:50 ` [bug#44620] [PATCH v3] " Alexandru-Sergiu Marton
2020-11-30 9:34 ` bug#44620: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874klqctkq.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=44620@debbugs.gnu.org \
--cc=brown121407@posteo.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).