From: "Ludovic Courtès" <ludo@gnu.org>
To: dftxbs3e <dftxbs3e@free.fr>
Cc: 44990@debbugs.gnu.org
Subject: [bug#44990] [PATCH] gnu: electrum: Update to 4.0.5.
Date: Fri, 11 Dec 2020 18:43:42 +0100 [thread overview]
Message-ID: <874kks5jch.fsf@gnu.org> (raw)
In-Reply-To: <ddfb7d856c3a0a8868579d38206ff963d28df421.camel@free.fr> (dftxbs3e@free.fr's message of "Tue, 01 Dec 2020 12:53:21 +0100")
Hi!
dftxbs3e <dftxbs3e@free.fr> skribis:
> Third time.. sorry.
>
> My biggest submission so far, please review carefully I can still count
> my submissions with my hand.
>
> Please strip the first mail from the mbox when using git-am. Because
> debbugs wont allow git-send-email to work without creating one bug per
> patch I am sending the first email with my regular email client to
> obtain the dedicated address and then using git-send-email.
Yeah, the (annoying) trick is to send the cover letter, get the number,
and then send the actual series:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
Overall the series LGTM. A couple of comments:
1. Could you please improve synopses and suggestions a bit, according
to the guidelines at
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>,
and wrap lines to 80 chars? Don’t lose your hair on it but at
least make sure to have full sentences in descriptions and so on.
2. The last patch moves a large chunks of eletrum ‘inputs’ to
‘propagated-inputs’. If you are sure this is justified, please add
a comment right above the ‘propagated-inputs’ field explaining
why. However, it may not be a good idea to propagate that much as
it “pollutes” the profile of users who install ‘electrum’, can lead
to collisions, etc.
Could you send a v2?
Thanks!
Ludo’.
next prev parent reply other threads:[~2020-12-11 18:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:53 [bug#44990] [PATCH] gnu: electrum: Update to 4.0.5 dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 1/8] gnu: Add python-qtpy dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 2/8] gnu: Add python-helpdev dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 3/8] gnu: Add python-qdarkstyle dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 4/8] gnu: Add python-bitstring dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 5/8] gnu: Add python-socks dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db dftxbs3e
2020-12-01 11:55 ` [bug#44990] [PATCH 8/8] gnu: electrum: Update to 4.0.5 dftxbs3e
2020-12-11 17:43 ` Ludovic Courtès [this message]
2020-12-11 19:53 ` [bug#44990] [PATCH v2 1/8] gnu: Add python-qtpy Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 2/8] gnu: Add python-helpdev Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 3/8] gnu: Add python-qdarkstyle Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 4/8] gnu: Add python-bitstring Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 5/8] gnu: Add python-socks Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db Léo Le Bouter via Guix-patches via
2020-12-11 19:53 ` [bug#44990] [PATCH v2 8/8] gnu: electrum: Update to 4.0.7 Léo Le Bouter via Guix-patches via
2020-12-11 19:55 ` Léo Le Bouter via Guix-patches via
2020-12-11 20:00 ` [bug#44990] [PATCH v2 1/8] gnu: Add python-qtpy Léo Le Bouter via Guix-patches via
2020-12-11 20:00 ` [bug#44990] [PATCH v2 2/8] gnu: Add python-helpdev Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 3/8] gnu: Add python-qdarkstyle Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 4/8] gnu: Add python-bitstring Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 5/8] gnu: Add python-socks Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db Léo Le Bouter via Guix-patches via
2020-12-11 20:01 ` [bug#44990] [PATCH v2 8/8] gnu: electrum: Update to 4.0.7 Léo Le Bouter via Guix-patches via
2020-12-11 20:18 ` [bug#44990] [PATCH v2 1/8] gnu: Add python-qtpy John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 2/8] gnu: Add python-helpdev John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 3/8] gnu: Add python-qdarkstyle John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 4/8] gnu: Add python-bitstring John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 5/8] gnu: Add python-socks John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db John Doe
2020-12-11 20:18 ` [bug#44990] [PATCH v2 8/8] gnu: electrum: Update to 4.0.7 John Doe
2020-12-21 8:18 ` [bug#44990] [PATCH v2 1/8] gnu: Add python-qtpy Efraim Flashner
2020-12-27 22:13 ` [bug#44990] [PATCH v3 0/8] gnu: electrum: Update to 4.0.9 John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 1/8] gnu: Add python-qtpy John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 2/8] gnu: Add python-helpdev John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 3/8] gnu: Add python-qdarkstyle John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 4/8] gnu: Add python-bitstring John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 5/8] gnu: Add python-socks John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db John Doe
2020-12-27 22:13 ` [bug#44990] [PATCH v3 8/8] gnu: electrum: Update to 4.0.9 John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 0/8] " John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 1/8] gnu: Add python-qtpy John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 2/8] gnu: Add python-helpdev John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 3/8] gnu: Add python-qdarkstyle John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 4/8] gnu: Add python-bitstring John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 5/8] gnu: Add python-socks John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 6/8] gnu: python-aiohttp-socks: Update to 0.5.5 John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 7/8] gnu: libsecp256k1: Update to 20200615-1-dbd41db John Doe
2020-12-27 22:26 ` [bug#44990] [PATCH v4 8/8] gnu: electrum: Update to 4.0.9 John Doe
2020-12-28 11:25 ` bug#44990: [PATCH v4 0/8] " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kks5jch.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44990@debbugs.gnu.org \
--cc=dftxbs3e@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).