From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yPWgFNfbEmCTUwAA0tVLHw (envelope-from ) for ; Thu, 28 Jan 2021 15:44:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qEt0ENfbEmCzTgAAB5/wlQ (envelope-from ) for ; Thu, 28 Jan 2021 15:44:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 763E09403AE for ; Thu, 28 Jan 2021 15:44:22 +0000 (UTC) Received: from localhost ([::1]:44466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l59T3-0003yu-7e for larch@yhetil.org; Thu, 28 Jan 2021 10:44:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l59Pq-0000H5-T3 for guix-patches@gnu.org; Thu, 28 Jan 2021 10:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l59Pq-0003gF-IH for guix-patches@gnu.org; Thu, 28 Jan 2021 10:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l59Pq-0002LW-FK for guix-patches@gnu.org; Thu, 28 Jan 2021 10:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jan 2021 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.16118484358976 (code B ref 45712); Thu, 28 Jan 2021 15:41:02 +0000 Received: (at 45712) by debbugs.gnu.org; 28 Jan 2021 15:40:35 +0000 Received: from localhost ([127.0.0.1]:49472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59PP-0002Kh-6t for submit@debbugs.gnu.org; Thu, 28 Jan 2021 10:40:35 -0500 Received: from mail-qk1-f181.google.com ([209.85.222.181]:46267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l59PN-0002KT-Hb for 45712@debbugs.gnu.org; Thu, 28 Jan 2021 10:40:33 -0500 Received: by mail-qk1-f181.google.com with SMTP id a7so5585034qkb.13 for <45712@debbugs.gnu.org>; Thu, 28 Jan 2021 07:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wm4myBLan58G7rlxtJTfgUeGB8gKz/g57WLM7A2VDJA=; b=BWq8GaOJOsPF1ReDVpJdVG3mwziKZ6KjTiMrTWmvpViwBgwkdmj6v4lKCh5AzhIvWU KF2XjOcnghnUPOwpokHIZkL+FSySJNFo6+Qg3SvQsqb7F/8xdT81apZJYlVlNXQTYtt5 lIANZa1Wh/ZENm5HDooRt8bW7VpL78PMbb+xc27xfdQ1XBST82kS7yYFuv+8rLkZgCrs TGVxo1/lRivr60XkFHVfmuUuZ2NhrIbaicfGFbHWyELJNY0GtLJakabfizmb1KOq7vGE rJWNutKjPPUyySHl8ePOBLTN8Kl1TZKuXZdZnVmfp6HKuKqnk0V92fB43V36NjNFO1Dg boMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=wm4myBLan58G7rlxtJTfgUeGB8gKz/g57WLM7A2VDJA=; b=miuWi3SwpShwIMonAdQQlwXlbVrjv3sEGhuGYZzXw6+zMNf8gxupJAhDjBQk2WyDLV YpE5Ft7jOo0YHr0sC9FbxtAd22v+8S7KrrLa20O00fSZXmaoNNbfwU2cP0Hiqr2n+Tsf 7jhVPpLzQAIG+XICTMsM1Y8k5lC6FzxVCIu88625JTsOcHBJOWWk8OHeFEgfA8z8lhBU yTQSxeCbSDBv7ZrGKaG3AtPXTiehb0CeoUNHEuzNDwbwYJ68ZV+RcnyfW1xIpiBNGVlO 0bHRtmo6YStoYTB5Ara8xW3l+GWITI/ae72Wh6oR+bKtu5dVS8xpgCrO64TvdBRhb/nh 2eiw== X-Gm-Message-State: AOAM530PoFxSveu6mSNKnhywQANl6/o0Fy7akzY5GfMNsrXPWosFyB6G LgGRnE4fWrqbZqcnnJosQvX9HX5Fdro= X-Google-Smtp-Source: ABdhPJwSJ8R6OX0HfAEmTLv2Z1zaILNZdJAVTeV/r67THiOWB+AqVP1+bhaThsEoEnllorAidDCzSg== X-Received: by 2002:ae9:ef55:: with SMTP id d82mr17002078qkg.243.1611848427768; Thu, 28 Jan 2021 07:40:27 -0800 (PST) Received: from hurd (dsl-10-141-243.b2b2c.ca. [72.10.141.243]) by smtp.gmail.com with ESMTPSA id y66sm3744927qka.17.2021.01.28.07.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 07:40:27 -0800 (PST) From: Maxim Cournoyer References: <87czxs3jel.fsf_-_@gmail.com> Date: Thu, 28 Jan 2021 10:40:26 -0500 In-Reply-To: (Lars-Dominik Braun's message of "Tue, 26 Jan 2021 09:39:22 +0100") Message-ID: <874kj1ysr9.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=BWq8GaOJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 763E09403AE X-Spam-Score: -1.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: yjzY6IaL4dlM Hi Lars, Lars-Dominik Braun writes: > Hi Maxim, > >> Attached is a small rework of your original patch. I've made the Python >> script standalone, which should make it easier to maintain. I've also >> refactored the tests somewhat and added your copyright information. >> Is this OK with you? > sure, no problem with the refactoring in gerenal, but I think you used > an old patchset. I sent a v2 to this issue, which had some changes to > the scripts and tests. > > I can=E2=80=99t test your patch properly unfortunately, because `make che= ck` > does not work on core-updates and trying to build any Python package on > core-updates triggers the requirements checker immediately:=20 > > validating 'attrs' > /gnu/store/hdjip92izsf9anfhd6ijgc9glvbi4dzv-python-attrs-bootstrap-19.3.0= /lib/python3.9/site-packages > ...checking requirements: ERROR: attrs=3D=3D19.3.0 The 'attrs=3D=3D19.3.0' > distribution was not found and is required by the application=E2=80=9D) > > Maybe that=E2=80=99s an issue with Python 3.9? > > Cheers, > Lars Doesn't that mean that the attrs requirement should be lifted from the bootstrap version? As its purpose is exactly this: breaking the cyclic dependency with itself. Maxim