From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id pyAIBqgFZ2CacQEAgWs5BA (envelope-from ) for ; Fri, 02 Apr 2021 13:53:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8D9yOqcFZ2AmXQAAB5/wlQ (envelope-from ) for ; Fri, 02 Apr 2021 11:53:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7C7D41A853 for ; Fri, 2 Apr 2021 13:53:11 +0200 (CEST) Received: from localhost ([::1]:60640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSIMQ-0000uV-Ft for larch@yhetil.org; Fri, 02 Apr 2021 07:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSIMI-0000sc-CV for guix-patches@gnu.org; Fri, 02 Apr 2021 07:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47735) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSIMI-0005C7-5q for guix-patches@gnu.org; Fri, 02 Apr 2021 07:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSIMI-0000J8-4R for guix-patches@gnu.org; Fri, 02 Apr 2021 07:53:02 -0400 Subject: bug#47513: [PATCH 00/12] Update jami and add jami-qt Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 02 Apr 2021 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Jack Hill , 47513-done@debbugs.gnu.org Mail-Followup-To: 47513@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 47513-done@debbugs.gnu.org id=D47513.16173643521139 (code D ref 47513); Fri, 02 Apr 2021 11:53:01 +0000 Received: (at 47513-done) by debbugs.gnu.org; 2 Apr 2021 11:52:32 +0000 Received: from localhost ([127.0.0.1]:59279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSILn-0000IJ-To for submit@debbugs.gnu.org; Fri, 02 Apr 2021 07:52:32 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:42703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSILl-0000I2-Mc for 47513-done@debbugs.gnu.org; Fri, 02 Apr 2021 07:52:30 -0400 Received: by mail-qv1-f53.google.com with SMTP id 30so2357023qva.9 for <47513-done@debbugs.gnu.org>; Fri, 02 Apr 2021 04:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=l3gMFHoz1XPVEtkeNpOmmW6OrBw9ZgCvqr1U9WKAhSM=; b=YSGjAdMgAvkKpW5j42Dx1mvjAIO62I4lUuOMfGw53di6OjQiNG46mvnxuiyKo0S4nW uEXCvyXFz8Q9P8e2pYd7hHy1TBm1wiuK6Mnwlls57lS2chKqLD2Ik7x2Na/9D23HyDkM DYQqkvC7xE6C4uNzGnd1J6RTSu0Hx9+nJNHopmxY5Gh2VphvoLWdGprCYZXql3FDLU6o Q3LrFY7N1VW9EaOycTu2032HN97HImryWXHIOUDrtHlPac+GYFenctUvEV+OFjih7XXp ZxF/NUtl1+bn8tQl8eHhWmfbGTWcFRpV4H2Zwrg/x6pA3Evc4fvMZppm3+xIBt+SpHcQ yh+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=l3gMFHoz1XPVEtkeNpOmmW6OrBw9ZgCvqr1U9WKAhSM=; b=atOSsBrBTKE+OCuz7+OhuZXLg4Y3PwcPC381WQZosYl/OZSOzq9q2H+cX4nOAm9Di0 cwP7AAmnUUA0/IENMR/jKkAbKoGiUArEbkiRq0E42ozVqaM2ao0KonPQPqwjiFv0A2Qb mWsIQ3hBFu3kiCMiuWD/hLn+Wnq6Mf3sh0jU7Shju2P44Fp+3yjOgFjQ999Uij+FELS4 HTCDi9BEEb3xRQDZzkQSpT58Qo9UnhPIz3YHolC47a5atGf+TajP4hDh/sFsUP/dueak dgPws/YQ47RaM879C52Odrk6qftusAda4aQZrbb+TbQ7cnRUnUWP6DcftHGzlJmsmg3u zWkQ== X-Gm-Message-State: AOAM533C9kYlxi7ME+tUZ70gYiths7OUBu31GMFUCTjxfbMc2J5Nx10W 7pO2QKyR4Nkiwm2qI3+Cy04= X-Google-Smtp-Source: ABdhPJzzjMMjEkKYoA27dZznQ7z6rqNq2CcDunpHCGBDnEIievwTXyYczjJYeElT+ZMQ81o/fw0ydw== X-Received: by 2002:a05:6214:2507:: with SMTP id gf7mr12340487qvb.40.1617364344052; Fri, 02 Apr 2021 04:52:24 -0700 (PDT) Received: from hurd (dsl-10-133-254.b2b2c.ca. [72.10.133.254]) by smtp.gmail.com with ESMTPSA id a187sm6885601qkd.69.2021.04.02.04.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 04:52:23 -0700 (PDT) From: Maxim Cournoyer References: <87y2e3kifn.fsf@gmail.com> Date: Fri, 02 Apr 2021 07:52:22 -0400 In-Reply-To: (Maxime Devos's message of "Thu, 01 Apr 2021 13:10:10 +0200") Message-ID: <874kgovr7t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617364391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=l3gMFHoz1XPVEtkeNpOmmW6OrBw9ZgCvqr1U9WKAhSM=; b=k0X2e01Zmw4Ki0OY/EMMtgO52QPH8X/4l6pqKKcS7tVzSUcVvIVKnhKYB0lKZ+xau2TKg+ A76UY0C5r0gN7P1Cn3KVqRC650otONsru3f5Utpn64PHEdRmsSug7myVo1faPLGE4VLTEw OYrt0ehc/kZmQb3Wd63etaLfSBc1e0ev9n4o5AI4RY1+WYcZAx06DR2vpTU+HrfwPn/Fkr 91ukqGcfwmi/weh5FoU23UGIaK5zelqC7W+JgMWgGB/+tbJvcHW1rdzIGen/vaPi8yJrSo Iv8zlnX7dKPrSkabukUv3tGk6Rq1mZNdYFPSFJiXmACYLoGzBlpTdioFK5yiZw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617364391; a=rsa-sha256; cv=none; b=nIN+QKSwp0sedsovBGPyp57Oa1BRa0rRAwCvo4TRuRW+T8a8lS3QnNZ36BDUzQPg/P5Zp1 u+Y4cuH+QAc5OB5exiWa7+yd0rgYBKKOojb3gZNVmO9r0zFO3uUGEBHBh4fncfzWVgxkSe /1it5Uqv8Jltn3Jf7yFgFlPd8OkMNFz6/MrQLO38xrqcTmJVRcQf/YwWH1GYHtpSMRgSSo UWCedVBXGljmFJL3I3A3zmV3YBn+40kgyawODavBkH1+Ngr7wRWh30Lp1BAB2awlkMFIO4 IpnTe6+2BQuhRM+94kPehinS2XFDDfjVd6c6Afbh2ac+mL5WWT/r34vOsPBm+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=YSGjAdMg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=YSGjAdMg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7C7D41A853 X-Spam-Score: 0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: zcBA7bo8dSwA Hi Maxime! Maxime Devos writes: > On Wed, 2021-03-31 at 01:14 -0400, Maxim Cournoyer wrote: >> Hello! >> >> I've finally picked up the packaging of Jami, which was becoming quite >> outdated in Guix. I haven't had much time to test the result yet, but a >> priori it seems to function as intended. >> >> Let me know how it works for you! > > It seems to work for me, however I needed to make a tiny change: > > > diff --git a/gnu/packages/jami.scm b/gnu/packages/jami.scm > index 67befe63a2..b73ad027fe 100644 > --- a/gnu/packages/jami.scm > +++ b/gnu/packages/jami.scm > @@ -554,7 +554,7 @@ decentralized calling using P2P-DHT.") > > ;;; Keep this until the Qt client matures enough to become the > ;;; main 'jami' client. > -(deprecated-package jami jami-gnome) > +#;(deprecated-package jami jami-gnome) > > (define-public jami-qt > (package > Jack in the thread made me notice about that as well; deprecated-package returns a package object, so it needs to be public-define'd the usual way: + +;;; Keep this until the Qt client matures enough to become the +;;; main 'jami' client. +(define-public jami + (deprecated-package "jami" jami-gnome)) And yes the package name is a string. I fixed this in a v2 patch series I sent along a problem propagating libringclient instead of libring for the jami-qt client (see: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47513#95). MUMI (issues.guix.gnu.org) sadly doesn't seem to have picked it up. [...] > Also, I didn't have any opportunity to actually call someone. [...] OK! I've tested it on my side with actual calls, so I feel confident it works fine. I've made a few last changes (using LIBWRAP when building libringclient so that it talks directly with libring instead of going through DBus, which allows to have it work even in a 'guix pack' and cleaning the list of imports) and pushed to master as e6b447cf756831e8339e6462647004d88132fa07. Thanks for the review! Maxim