From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id m+ZwNCydgGANgAAAgWs5BA (envelope-from ) for ; Wed, 21 Apr 2021 23:46:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iNjULiydgGAXBwAAbx9fmQ (envelope-from ) for ; Wed, 21 Apr 2021 21:46:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4EED5267F6 for ; Wed, 21 Apr 2021 23:46:20 +0200 (CEST) Received: from localhost ([::1]:35972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZKfr-0005TM-Di for larch@yhetil.org; Wed, 21 Apr 2021 17:46:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZKfa-0005SQ-Nd for guix-patches@gnu.org; Wed, 21 Apr 2021 17:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZKfZ-0003kN-U7 for guix-patches@gnu.org; Wed, 21 Apr 2021 17:46:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZKfZ-0005dk-RZ for guix-patches@gnu.org; Wed, 21 Apr 2021 17:46:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47930] [PATCH] gnu: Add pbgzip. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Apr 2021 21:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47930 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roel Janssen , 47930@debbugs.gnu.org Received: via spool by 47930-submit@debbugs.gnu.org id=B47930.161904151921626 (code B ref 47930); Wed, 21 Apr 2021 21:46:01 +0000 Received: (at 47930) by debbugs.gnu.org; 21 Apr 2021 21:45:19 +0000 Received: from localhost ([127.0.0.1]:59966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZKer-0005cj-OQ for submit@debbugs.gnu.org; Wed, 21 Apr 2021 17:45:19 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:40022 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZKel-0005cL-S1 for 47930@debbugs.gnu.org; Wed, 21 Apr 2021 17:45:16 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1619041506; bh=SS5Ogf8+T4I5hBvO3iVpCbmuVp8ebl4dRZ/oO5X8z0w=; h=From:To:Subject:In-Reply-To:References:Date; b=WheI20Oh4M46e5v722VnmYea8LRHEdfuLZ1h1mUZEMentmyccya2od+Kdi5gYYh3S 1Qg0cX0ASwFgfoNomoHls7fyJBoBQxHhZcquNi9owz3qgaNdQSU+RByjQwi3OQfkDR Y6mJhKD5694ZlMslzs22KJj+KKrOSphbMYrbTHfo= In-Reply-To: References: Date: Wed, 21 Apr 2021 23:45:05 +0200 Message-ID: <874kfz71ni.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619041580; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cWI6OgMXdvKcPg70Q2DWcoi+z2OtPEPqmHiqegCpXzQ=; b=TRsiFSyWrv57GQSifYW11CkpK5Vv4yFJeHJE9md5eeqv25vXUuRi6CM6a9LUJpHmkFf1Ee aRqnVIOZQCozI0tDTRoZ7TMSNWJO7azlZc2yXSKSev0zrj62lUpZuhSG2zNkixT5S96AOm hfvKpIi/PayNIhpfSe8vI7nMPE2Y+S/v4WvFjFc2opQaM0nleD+AB5PzH99bj1w1M1L7NK ZODK9+M7r8IItE8C3YeWs1oOI22LmThngxQSbac8PDs01eED2be1g0SErtrtvzTWwG8sVk UWx/TZPCw58dE+rGFtd1OFo6W9sq59fs0OB5UbV+GljkzeenSY2rKNRoozCEzA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619041580; a=rsa-sha256; cv=none; b=sb4wX6d9jXyec0JlaDB6gRj2foghylCEIbjIWU+fGpM8oLnzfKwsCdH7FAV6dFAHpy03Xh HUFJrG/ytRyM4Ardk/9B0HnIdo8RTAHVjdcwKisix4Y+ZTlbc25vBVLr8FPd/fJQ/g4iJc K4VKeuwYnyrRMCJ/1CcDc/sGXhX/NCq9Ovs2UGPUjPSRXiB7ZNdi3UE03DjYkJIMszU3MU fpNki81b8nsJ8Gy3IlNBd96nlK8XcbfjFyKJHsw0B1tfiEGKPJ4OGqSh97lfCgU0PC6Aa4 3f4AefRJTDuEWbW08bzNBKY7Q51080IiQ0bsSOV+smFWN5nsqgOHM/+e/9+M+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=WheI20Oh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=WheI20Oh; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4EED5267F6 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: ub4/SjpPRAy/ On Wed, Apr 21 2021, Roel Janssen wrote: > * gnu/packages/bioinformatics.scm (pbgzip): New variable. > > [...] >=20=20 > +(define-public pbgzip > + (let ((commit "2b09f97b5f20b6d83c63a5c6b408d152e3982974")) > + (package > + (name "pbgzip") > + (version (string-take commit 7)) I think using (git-version VERSION REVISION COMMIT) is preferred. Something like (git-version "0.0.0" "0" commit). > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nh13/pbgzip") > + (commit commit))) > + (file-name (string-append name "-" version)) Use (git-file-name name version). > + (sha256 > + (base32 > + "1mlmq0v96irbz71bgw5zcc43g1x32zwnxx21a5p1f1ch4cikw1yd"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (zero? (system* "sh" "autogen.sh"))))))) IIRC, phases don=E2=80=99t have to return #t, so you could remove =E2=80=98= zero?=E2=80=99. Builds fine, but I haven=E2=80=99t tested it.