From: Xinglu Chen <public@yoctocell.xyz>
To: Roel Janssen <roel@gnu.org>, 47930@debbugs.gnu.org
Subject: [bug#47930] [PATCH] gnu: Add pbgzip.
Date: Wed, 21 Apr 2021 23:45:05 +0200 [thread overview]
Message-ID: <874kfz71ni.fsf@yoctocell.xyz> (raw)
In-Reply-To: <eb1b7cd3-e60b-46c5-da4a-371b5038b3a3@gnu.org>
On Wed, Apr 21 2021, Roel Janssen wrote:
> * gnu/packages/bioinformatics.scm (pbgzip): New variable.
>
> [...]
>
> +(define-public pbgzip
> + (let ((commit "2b09f97b5f20b6d83c63a5c6b408d152e3982974"))
> + (package
> + (name "pbgzip")
> + (version (string-take commit 7))
I think using (git-version VERSION REVISION COMMIT) is preferred.
Something like (git-version "0.0.0" "0" commit).
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/nh13/pbgzip")
> + (commit commit)))
> + (file-name (string-append name "-" version))
Use (git-file-name name version).
> + (sha256
> + (base32
> + "1mlmq0v96irbz71bgw5zcc43g1x32zwnxx21a5p1f1ch4cikw1yd"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'autogen
> + (lambda _
> + (zero? (system* "sh" "autogen.sh")))))))
IIRC, phases don’t have to return #t, so you could remove ‘zero?’.
Builds fine, but I haven’t tested it.
next prev parent reply other threads:[~2021-04-21 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:26 [bug#47930] [PATCH] gnu: Add pbgzip Roel Janssen
2021-04-21 21:44 ` Xinglu Chen
2021-04-21 21:45 ` Xinglu Chen [this message]
2021-04-22 16:40 ` Maxime Devos
2021-04-29 7:29 ` Efraim Flashner
2021-04-29 12:22 ` Roel Janssen
2021-04-30 8:30 ` Xinglu Chen
2021-04-30 11:48 ` Roel Janssen
2021-04-30 11:53 ` Efraim Flashner
2021-04-30 16:47 ` bug#47930: " Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kfz71ni.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=47930@debbugs.gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).