From: "Ludovic Courtès" <ludo@gnu.org>
To: Sergiu Ivanov <sivanov@colimite.fr>
Cc: 48128@debbugs.gnu.org
Subject: [bug#48128] [PATCH] Add font-montserrat.
Date: Mon, 03 May 2021 18:13:45 +0200 [thread overview]
Message-ID: <874kfjyeva.fsf@gnu.org> (raw)
In-Reply-To: <87im43wlcl.fsf@colimite.fr> (Sergiu Ivanov's message of "Fri, 30 Apr 2021 22:47:38 +0200")
Hi Sergiu,
Sergiu Ivanov <sivanov@colimite.fr> skribis:
> I retrieve the release zipball from GitHub using a direct url-fetch
> rather than git-fetch, because I've seen both in fonts.scm. If you think
> git-fetch is more appropriate, I'll change the method.
[...]
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))
This is a generated tarball that may change over time, which is why
‘guix lint’ warns about it. So yes, I think you should use ‘git-fetch’
instead.
You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
lint’ suggests.
There are also a couple of ‘guix lint’ warnings that I’ll let you
check. :-)
> + (synopsis "The Montserat font")
^
Missing ‘r’.
Could you send an updated patch?
Thanks in advance,
Ludo’.
next prev parent reply other threads:[~2021-05-03 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 20:47 [bug#48128] [PATCH] Add font-montserrat Sergiu Ivanov
2021-05-03 16:13 ` Ludovic Courtès [this message]
2021-05-05 20:17 ` Sergiu Ivanov
2021-05-08 10:14 ` bug#48128: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kfjyeva.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48128@debbugs.gnu.org \
--cc=sivanov@colimite.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).