From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WEjzND6pkmCuigAAgWs5BA (envelope-from ) for ; Wed, 05 May 2021 16:18:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eEibMD6pkmDLJgAA1q6Kng (envelope-from ) for ; Wed, 05 May 2021 14:18:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F1612D8EC for ; Wed, 5 May 2021 16:18:38 +0200 (CEST) Received: from localhost ([::1]:42888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leIMH-0000sQ-8D for larch@yhetil.org; Wed, 05 May 2021 10:18:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leIKl-00087x-3R for guix-patches@gnu.org; Wed, 05 May 2021 10:17:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leIKk-00087w-6k for guix-patches@gnu.org; Wed, 05 May 2021 10:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leIKk-0004HD-2Y for guix-patches@gnu.org; Wed, 05 May 2021 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 May 2021 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47824 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 47824-submit@debbugs.gnu.org id=B47824.162022419516427 (code B ref 47824); Wed, 05 May 2021 14:17:02 +0000 Received: (at 47824) by debbugs.gnu.org; 5 May 2021 14:16:35 +0000 Received: from localhost ([127.0.0.1]:60526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIKJ-0004Gt-1n for submit@debbugs.gnu.org; Wed, 05 May 2021 10:16:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leIKH-0004Gl-17 for 47824@debbugs.gnu.org; Wed, 05 May 2021 10:16:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45198) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leIK9-0007mB-VU; Wed, 05 May 2021 10:16:25 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36482 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1leIK8-0001on-CQ; Wed, 05 May 2021 10:16:25 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> Date: Wed, 05 May 2021 16:16:22 +0200 In-Reply-To: <20210419081744.7247-3-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Mon, 19 Apr 2021 10:17:44 +0200") Message-ID: <874kfhjmfd.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620224318; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=VoE6SGVf2+yx6T06KclXWG23eeedJmWnsv/8AMy+aQs=; b=p2Hgomi1h309czAnbM37VDVEJMjXM5Kzn0fK4LMAoGDVK9Dxu17HZcHjreQCGcnbf2bkW9 TlfVHE9iSI7KDRGiLRMst3PdNjgscHRZCLK3CW5Y04+1FcWMRHGSw5eIFNCRN65Epj9BDL NvkZ9u7sGS6clW4EuqUsTT5XXLAEHKaPyvUfKDgC+OAWVz1pfQwaxtIlShwEfQ7pVDaZS5 3e9OAzoCYQ2vZIMrSmkUE9qNBbGlMsK1ER3D30DGTRMAkoQzuRyHwifE6IOilfFtqEptdf /M3609S6378Xox5aVhzcT5zAJ1YvZRmjDzA6Gu6DoqcBlto9tFnMFWsPCFFxlg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620224318; a=rsa-sha256; cv=none; b=hif6xqBnX8kaZhysmLVPcA9KCcSrMXpieXnM+dzUnopmFAv1RqYwL2CRrvjXet/w+2u+yO HfIhA1DODmGCBjwer4qfchUmwWZ+8MsshrivPvP9UoaWDUXD3xUbeEFAfvt5/sOm9iK/jz Nz14keWtOyqeKFUjv74OJNiUakLv5SHUM1Lz5S0ym0QQ6sg9TV5GZV0MHpuvacpDJ20RKx gT2u9sY1Kytmsw6Z3CNbncwvWyR+zpQQiwqKuLIZsNaG7ofzkHHS0evxoD2HxbJw6bjnMC NwvkIdulOeVFx6yGt5h6veMxFm+NAN3LhMqGTlTZFFaErQr4/zHYTHNdE9/9cQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8F1612D8EC X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ze3g3MM4PrCr Hi Leo, On a cursory look, all three patches LGTM. One nit: > + "exec " > + (assoc-ref inputs "guile-runtime") > + "/bin/guile " args))) [...] > ("guile" ,guile-3.0) > ("pkg-config" ,pkg-config) > ("texinfo" ,texinfo))) > - (propagated-inputs > - `(("guile-sdl2" ,guile3.0-sdl2))) > + (inputs > + `(("guile-sdl2" ,guile3.0-sdl2) > + ("guile-runtime" ,guile-3.0))) I think it=E2=80=99s best to not play trick with labels, and to always use = the package name as the label (to facilitate migration on the day where we get rid of labels, who knows=E2=80=A6). A common pattern for the case above is to provide =E2=80=9Cguile=E2=80=9D b= oth as native input and input, and to write: (assoc-ref (or native-inputs inputs) "guile") Thanks, and congrats to the Lisp Game Jam participants! Ludo=E2=80=99.